Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): remove constant from pre validate test #996

Open
wants to merge 1 commit into
base: yoav/blockifier/remove_constants/pre_validate/03
Choose a base branch
from

Conversation

yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented Sep 24, 2024

This change is Reviewable

Copy link
Contributor Author

yoavGrs commented Sep 24, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @yoavGrs and the rest of your teammates on Graphite Graphite

@yoavGrs yoavGrs marked this pull request as ready for review September 24, 2024 14:11
@yoavGrs yoavGrs self-assigned this Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.28%. Comparing base (b7a0ccf) to head (6684776).

Additional details and impacted files
@@                                Coverage Diff                                @@
##           yoav/blockifier/remove_constants/pre_validate/03     #996   +/-   ##
=================================================================================
  Coverage                                             70.28%   70.28%           
=================================================================================
  Files                                                    87       87           
  Lines                                                 11119    11119           
  Branches                                              11119    11119           
=================================================================================
  Hits                                                   7815     7815           
  Misses                                                 2916     2916           
  Partials                                                388      388           
Flag Coverage Δ
70.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants