feat(blockifier): explicit names for versioned constants JSONs

[dorimedini-starkware]

This change is 

[Yoni-Starkware]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[Yoni-Starkware]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.57%. Comparing base (b0cfe82) to head (e0b54aa).
Report is 125 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (e0b54aa). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (b0cfe82)	HEAD (e0b54aa)
	3	1

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #998       +/-   ##
===========================================
- Coverage   74.18%   62.57%   -11.62%     
===========================================
  Files         359      125      -234     
  Lines       36240    15755    -20485     
  Branches    36240    15755    -20485     
===========================================
- Hits        26886     9859    -17027     
+ Misses       7220     5115     -2105     
+ Partials     2134      781     -1353     

Flag	Coverage Δ
	62.57% <100.00%> (-11.62%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yoni-Starkware]

Reviewed 8 of 9 files at r3, all commit messages.
Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/papyrus_execution/src/lib.rs line 878 at r3 (raw file):

            VersionedConstants::get(blockifier_starknet_version)
        }
        None => VersionedConstants::latest_constants(),

Why do they need this arm? they take the latest if there is no match.
So either remove it or check v0_13_3 explicitly

(also, they are missing 0.13.1.1 and 0.13.2.1... a safer way is to assert that the given version is > than the last supported. but non-blocking since it's out of scope)

Code quote:

            } else {
                BlockifierStarknetVersion::V0_13_3
            };
            VersionedConstants::get(blockifier_starknet_version)
        }
        None => VersionedConstants::latest_constants(),

[dorimedini-starkware]

Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on @dan-starkware, @dorimedini-starkware, and @ShahakShama)

---

crates/papyrus_execution/src/lib.rs line 878 at r3 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Why do they need this arm? they take the latest if there is no match.
So either remove it or check v0_13_3 explicitly

(also, they are missing 0.13.1.1 and 0.13.2.1... a safer way is to assert that the given version is > than the last supported. but non-blocking since it's out of scope)

main Q is why are there two different structs?
@ShahakShama or @dan-starkware PTAL at this: looks like you should be using the blockifier StarknetVersion enum instead of strings

[dorimedini-starkware]

Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on @dan-starkware, @dorimedini-starkware, and @ShahakShama)

---

crates/papyrus_execution/src/lib.rs line 878 at r3 (raw file):

Previously, dorimedini-starkware wrote…

main Q is why are there two different structs?
@ShahakShama or @dan-starkware PTAL at this: looks like you should be using the blockifier StarknetVersion enum instead of strings

item to track this issue, following this conversation

[Yoni-Starkware]

Reviewed 1 of 9 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[Yoni-Starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)