Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InteractionElements LookupValues and trace_generation #812

Conversation

shaharsamocha7
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 commented Aug 27, 2024

This change is Reviewable

Copy link
Collaborator Author

shaharsamocha7 commented Aug 27, 2024

@shaharsamocha7 shaharsamocha7 marked this pull request as ready for review August 27, 2024 08:38
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.65%. Comparing base (f14134e) to head (51446b2).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #812      +/-   ##
==========================================
+ Coverage   91.48%   92.65%   +1.16%     
==========================================
  Files          92       89       -3     
  Lines       12489    12048     -441     
  Branches    12489    12048     -441     
==========================================
- Hits        11426    11163     -263     
+ Misses        952      778     -174     
+ Partials      111      107       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Refactor_wide_fibonacci_Remove_lookup_-_each_row_contain_independent_instance branch from 1d16029 to 4ed5628 Compare August 27, 2024 08:45
@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Remove_InteractionElements_LookupValues_and_trace_generation branch from df22ee6 to a1cfa56 Compare August 27, 2024 08:45
@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Refactor_wide_fibonacci_Remove_lookup_-_each_row_contain_independent_instance branch from 4ed5628 to d247028 Compare August 27, 2024 09:13
@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Remove_InteractionElements_LookupValues_and_trace_generation branch 2 times, most recently from 93860ac to b80d23f Compare August 27, 2024 09:15
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 13 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Refactor_wide_fibonacci_Remove_lookup_-_each_row_contain_independent_instance branch from d247028 to b13b78f Compare August 27, 2024 12:06
@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Remove_InteractionElements_LookupValues_and_trace_generation branch from b80d23f to 975031a Compare August 27, 2024 12:06
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Refactor_wide_fibonacci_Remove_lookup_-_each_row_contain_independent_instance branch from b13b78f to 6429ed8 Compare August 27, 2024 15:26
@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Remove_InteractionElements_LookupValues_and_trace_generation branch from 975031a to 272fe9b Compare August 27, 2024 15:26
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Refactor_wide_fibonacci_Remove_lookup_-_each_row_contain_independent_instance branch from 6429ed8 to 2fafedc Compare August 28, 2024 08:55
Copy link
Contributor

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 13 files at r1, 1 of 3 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Refactor_wide_fibonacci_Remove_lookup_-_each_row_contain_independent_instance branch from 2fafedc to 74482bf Compare August 29, 2024 09:32
@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Remove_InteractionElements_LookupValues_and_trace_generation branch from 272fe9b to 9b1cadf Compare August 29, 2024 09:32
Copy link
Contributor

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

Copy link
Collaborator Author

shaharsamocha7 commented Aug 29, 2024

Merge activity

@shaharsamocha7 shaharsamocha7 changed the base branch from 08-27-Refactor_wide_fibonacci_Remove_lookup_-_each_row_contain_independent_instance to graphite-base/812 August 29, 2024 10:23
@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Remove_InteractionElements_LookupValues_and_trace_generation branch from 9b1cadf to fd1a9ff Compare August 29, 2024 11:09
Copy link
Contributor

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)


crates/prover/src/trace_generation/prove.rs line 1 at r6 (raw file):

use itertools::Itertools;

This file should be deleted no?

@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Remove_InteractionElements_LookupValues_and_trace_generation branch from fd1a9ff to 17517e6 Compare August 29, 2024 11:33
Copy link
Collaborator Author

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 11 of 13 files reviewed, 1 unresolved discussion (waiting on @alonh5)


crates/prover/src/trace_generation/prove.rs line 1 at r6 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

This file should be deleted no?

Yeah, merge conflict :(

Copy link
Collaborator Author

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r7.
Reviewable status: 12 of 13 files reviewed, 1 unresolved discussion (waiting on @alonh5)

@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Remove_InteractionElements_LookupValues_and_trace_generation branch from 17517e6 to 355dd0f Compare August 29, 2024 11:51
@shaharsamocha7 shaharsamocha7 changed the base branch from graphite-base/812 to dev August 29, 2024 11:52
@shaharsamocha7 shaharsamocha7 force-pushed the 08-27-Remove_InteractionElements_LookupValues_and_trace_generation branch from 355dd0f to 51446b2 Compare August 29, 2024 11:52
Copy link
Collaborator Author

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)

Copy link
Contributor

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@shaharsamocha7 shaharsamocha7 merged commit e5209bf into dev Aug 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants