Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function. #816

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Remove unused function. #816

merged 1 commit into from
Sep 2, 2024

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Sep 2, 2024

This change is Reviewable

Copy link
Contributor Author

alonh5 commented Sep 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite Graphite

@alonh5 alonh5 force-pushed the 09-02-remove_unused_function branch from 7011965 to e585b26 Compare September 2, 2024 14:00
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (5bd3f1d) to head (e585b26).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #816      +/-   ##
==========================================
+ Coverage   92.65%   92.76%   +0.10%     
==========================================
  Files          89       89              
  Lines       12055    12041      -14     
  Branches    12055    12041      -14     
==========================================
  Hits        11170    11170              
+ Misses        778      764      -14     
  Partials      107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@alonh5 alonh5 merged commit 1ee6a70 into dev Sep 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants