Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to CPU in small size. #824

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Sep 8, 2024

This change is Reviewable

Copy link
Contributor Author

alonh5 commented Sep 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite Graphite

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 8.69565% with 21 lines in your changes missing coverage. Please review.

Project coverage is 92.60%. Comparing base (1ee6a70) to head (503e901).

Files with missing lines Patch % Lines
crates/prover/src/core/backend/simd/quotients.rs 8.69% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #824      +/-   ##
==========================================
- Coverage   92.76%   92.60%   -0.17%     
==========================================
  Files          89       89              
  Lines       12041    12064      +23     
  Branches    12041    12064      +23     
==========================================
+ Hits        11170    11172       +2     
- Misses        764      785      +21     
  Partials      107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@alonh5 alonh5 merged commit 2abcb2b into dev Sep 9, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants