Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logup - rename claimed_sum to total_sum #825

Conversation

shaharsamocha7
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 commented Sep 8, 2024

Rename claimed_sum to total_sum
Take total_sum from cum_sum column


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (e9c6ba2) to head (62932c1).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #825      +/-   ##
==========================================
- Coverage   91.98%   91.95%   -0.03%     
==========================================
  Files          90       90              
  Lines       12198    12195       -3     
  Branches    12198    12195       -3     
==========================================
- Hits        11220    11214       -6     
- Misses        872      875       +3     
  Partials      106      106              
Flag Coverage Δ
91.95% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaharsamocha7 shaharsamocha7 force-pushed the 09-03-Revert_logup_without_is_first branch from a3a9330 to 1d55732 Compare September 17, 2024 11:01
@shaharsamocha7 shaharsamocha7 force-pushed the 09-08-Logup_-_rename_claimed_sum_to_total_sum_Take_total_sum_from_cum_sum_column branch from 483abed to 4095bd6 Compare September 17, 2024 11:01
@shaharsamocha7 shaharsamocha7 force-pushed the 09-03-Revert_logup_without_is_first branch from 1d55732 to 6272714 Compare September 17, 2024 12:18
@shaharsamocha7 shaharsamocha7 force-pushed the 09-08-Logup_-_rename_claimed_sum_to_total_sum_Take_total_sum_from_cum_sum_column branch from 4095bd6 to f465a76 Compare September 17, 2024 12:29
@shaharsamocha7 shaharsamocha7 marked this pull request as ready for review September 17, 2024 12:30
This was referenced Sep 18, 2024
Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)


crates/prover/src/constraint_framework/logup.rs line 173 at r2 (raw file):

        };

        // The last element in bit-reversed order of the the circle order is at index 1.

We should come up with a name for this order, and maybe constants like %sOrder::Last, etc.

@shaharsamocha7 shaharsamocha7 force-pushed the 09-08-Logup_-_rename_claimed_sum_to_total_sum_Take_total_sum_from_cum_sum_column branch from f465a76 to ffa1666 Compare September 22, 2024 10:14
Copy link
Collaborator Author

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @Alon-Ti)


crates/prover/src/constraint_framework/logup.rs line 173 at r2 (raw file):

Previously, Alon-Ti wrote…

We should come up with a name for this order, and maybe constants like %sOrder::Last, etc.

For now I called it bit-reversed circle domain order
Maybe in the future we will want an Order Struct but I think it is a premature now.

Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@shaharsamocha7 shaharsamocha7 changed the base branch from 09-03-Revert_logup_without_is_first to graphite-base/825 September 24, 2024 11:20
@shaharsamocha7 shaharsamocha7 force-pushed the 09-08-Logup_-_rename_claimed_sum_to_total_sum_Take_total_sum_from_cum_sum_column branch from ffa1666 to 1a0ef77 Compare September 24, 2024 11:20
@shaharsamocha7 shaharsamocha7 changed the base branch from graphite-base/825 to dev September 24, 2024 11:21
Take total_sum from cum_sum column
@shaharsamocha7 shaharsamocha7 force-pushed the 09-08-Logup_-_rename_claimed_sum_to_total_sum_Take_total_sum_from_cum_sum_column branch from 1a0ef77 to 62932c1 Compare September 24, 2024 11:21
@shaharsamocha7 shaharsamocha7 merged commit 75b94f9 into dev Sep 24, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants