-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logup - rename claimed_sum to total_sum #825
Logup - rename claimed_sum to total_sum #825
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shaharsamocha7 and the rest of your teammates on Graphite |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #825 +/- ##
==========================================
- Coverage 91.98% 91.95% -0.03%
==========================================
Files 90 90
Lines 12198 12195 -3
Branches 12198 12195 -3
==========================================
- Hits 11220 11214 -6
- Misses 872 875 +3
Partials 106 106
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a3a9330
to
1d55732
Compare
483abed
to
4095bd6
Compare
1d55732
to
6272714
Compare
4095bd6
to
f465a76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
crates/prover/src/constraint_framework/logup.rs
line 173 at r2 (raw file):
}; // The last element in bit-reversed order of the the circle order is at index 1.
We should come up with a name for this order, and maybe constants like %sOrder::Last
, etc.
f465a76
to
ffa1666
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @Alon-Ti)
crates/prover/src/constraint_framework/logup.rs
line 173 at r2 (raw file):
Previously, Alon-Ti wrote…
We should come up with a name for this order, and maybe constants like
%sOrder::Last
, etc.
For now I called it bit-reversed circle domain order
Maybe in the future we will want an Order Struct but I think it is a premature now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)
ffa1666
to
1a0ef77
Compare
Take total_sum from cum_sum column
1a0ef77
to
62932c1
Compare
Rename claimed_sum to total_sum
Take total_sum from cum_sum column
This change is