Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State machine prover #845

Open
wants to merge 1 commit into
base: 09-18-State_machine_AIR
Choose a base branch
from

Conversation

shaharsamocha7
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 commented Sep 19, 2024

This change is Reviewable

Copy link
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shaharsamocha7 and the rest of your teammates on Graphite Graphite

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (f86b74a) to head (529bc8b).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           09-18-State_machine_AIR     #845      +/-   ##
===========================================================
+ Coverage                    92.21%   92.29%   +0.08%     
===========================================================
  Files                           90       90              
  Lines                        12322    12322              
  Branches                     12322    12322              
===========================================================
+ Hits                         11363    11373      +10     
+ Misses                         853      844       -9     
+ Partials                       106      105       -1     
Flag Coverage Δ
92.29% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@shaharsamocha7 shaharsamocha7 force-pushed the 09-18-State_machine_AIR branch 2 times, most recently from 7acbcd9 to f86b74a Compare September 24, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants