Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bit reverse coset order #877

Merged
merged 1 commit into from
Nov 12, 2024
Merged

bit reverse coset order #877

merged 1 commit into from
Nov 12, 2024

Conversation

ohad-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ohad-starkware and the rest of your teammates on Graphite Graphite

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.84%. Comparing base (8385e54) to head (774531a).

Files with missing lines Patch % Lines
crates/prover/src/core/utils.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #877      +/-   ##
==========================================
- Coverage   91.92%   91.84%   -0.08%     
==========================================
  Files          92       92              
  Lines       12626    12636      +10     
  Branches    12626    12636      +10     
==========================================
  Hits        11606    11606              
- Misses        910      920      +10     
  Partials      110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 774531a Previous: f6214d1 Ratio
iffts/simd ifft/22 14471282 ns/iter (± 210148) 6919803 ns/iter (± 229254) 2.09
iffts/simd ifft/23 33327312 ns/iter (± 467921) 15457562 ns/iter (± 351223) 2.16
iffts/simd ifft/24 66548994 ns/iter (± 642133) 31678304 ns/iter (± 464426) 2.10
iffts/simd ifft/26 283687570 ns/iter (± 2171315) 138289295 ns/iter (± 2389141) 2.05
iffts/simd ifft/27 628376924 ns/iter (± 10538946) 312325137 ns/iter (± 5094310) 2.01
merkle throughput/simd merkle 34770733 ns/iter (± 373636) 14690867 ns/iter (± 434150) 2.37

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ohad-starkware)

@ohad-starkware ohad-starkware merged commit 6adfb88 into dev Nov 12, 2024
16 of 18 checks passed
@ohad-starkware ohad-starkware deleted the ohad/bit_reverse_coset branch November 12, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants