Add generate link to book appointment #390
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 9, 2022 00:12
evbambly
requested changes
Jul 9, 2022
| @@ -146,3 +148,11 @@ export function validateBookAppointment( | |||
| appointment: appointmentToBook, | |||
| }; | |||
| } | |||
|
|
|||
| function generateRandom(complexity: number = 4) { | |||
There was a problem hiding this comment.
Why not use a library to generate UIDs?
| (await request.get()) as FirebaseFirestore.QuerySnapshot<DbAppointment>; | ||
|
|
||
| const ret = toDbAppointments(appointments); | ||
| if (ret.length > 1) { |
| throw Error("there is more then one appointment with this share link!"); | ||
| } | ||
|
|
||
| if (ret.length == 0) { |
| request: FunctionsApi.GetSharedLinkAppointmentRequest, | ||
| callerId: string | ||
| ): Promise<FunctionsApi.GetSharedLinkAppointmentResponse> { | ||
| if (callerId !== request.donorId) { |
There was a problem hiding this comment.
Could this API be called by an unregistered user?
|
|
||
| const appointment = (await callTarget()).appointment; | ||
|
|
||
| expect(appointment).not.toBeNaN(); |
There was a problem hiding this comment.
Do you mean to test "not to be undefined"?
| ).rejects.toThrow(Error); | ||
| }); | ||
|
|
||
| test("Returns available appointments is ascending start time order", async () => { |
There was a problem hiding this comment.
I'm not sure I understand the test title.
| return appointment; | ||
| } | ||
|
|
||
| test("Not authenticated", async () => { |
There was a problem hiding this comment.
As per previous, this should not stop users from accessing the API.
| await setAppointment(appointment); | ||
| return appointment; | ||
| } | ||
|
|
There was a problem hiding this comment.
What about the logic test cases,
as written in getAppointmentByShareLink?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.