Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change (docker): Combine nginx and php to a single image for ASP with env var support for configuration #70

Commits on Nov 22, 2023

  1. Change (docker): Combine nginx and php to a single image for ASP wi…

    …th env var support for configuration
    
    In <= v3.2.0, `asp` had separate `nginx` and `php` images.
    
    Now: `asp` image containing both `nginx` and `php`, with environment variable support, and entrypoint that sets the correct permissions.
    
    Benefits:
    
    - Easier to deploy / upgrade. No need to separate `nginx` and `php` containers
    - Environment variable configuration means no more need to mount config into `asp` container
    - Entrypoint script sets permissions on volumes. `init-container` should only need to set permissions for `db` volume
    
    Notable changes:
    - Add documentation for upgrading docker images to v3.3.x from prior versions
    - Update `./docs/examples`
    - Add tests for production builds for examples in `./docs/examples`
    
    Closes #69
    leojonathanoh committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    0deb8c6 View commit details
    Browse the repository at this point in the history