Fix features flags loading (#1873)

stateful · Dec 20, 2024 · 30bf0ce · 30bf0ce
1 parent 79dd5b7
commit 30bf0ce
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 33 deletions.
diff --git a/src/extension/extension.ts b/src/extension/extension.ts
@@ -494,6 +494,7 @@ export class RunmeExtension {
         const session = await StatefulAuthProvider.instance.ensureSession()
         const nunmeIdentity = session ? RunmeIdentity.ALL : getServerLifecycleIdentity()
         await commands.executeCommand('runme.lifecycleIdentitySelection', nunmeIdentity)
+        kernel.updateFeatureContext('statefulAuth', !!session)
       } catch (error) {
         let message
         if (error instanceof Error) {

diff --git a/src/extension/kernel.ts b/src/extension/kernel.ts
@@ -116,7 +116,6 @@ import { CommandModeEnum } from './grpc/runner/types'
 import { GrpcReporter } from './reporter'
 import { EnvStoreMonitorWithSession } from './panels/notebook'
 import { SignedIn } from './signedIn'
-import { StatefulAuthProvider } from './provider/statefulAuth'
 
 enum ConfirmationItems {
   Yes = 'Yes',
@@ -203,44 +202,42 @@ export class Kernel implements Disposable {
     this.#onlySignedIn = new SignedIn(this)
     this.#disposables.push(this.#onlySignedIn)
 
-    StatefulAuthProvider.instance.currentSession().then((session) => {
-      const packageJSON = context?.extension?.packageJSON || {}
-      const featContext: FeatureContext = {
-        os: os.platform(),
-        vsCodeVersion: version as string,
-        extensionVersion: packageJSON?.version,
-        githubAuth: false,
-        statefulAuth: !!session,
-        extensionId: context?.extension?.id as ExtensionName,
-      }
+    const packageJSON = this.context?.extension?.packageJSON || {}
+    const featContext: FeatureContext = {
+      os: os.platform(),
+      vsCodeVersion: version as string,
+      extensionVersion: packageJSON?.version,
+      githubAuth: false,
+      statefulAuth: false,
+      extensionId: this.context?.extension?.id as ExtensionName,
+    }
 
-      const runmeFeatureSettings = workspace.getConfiguration('runme.features')
-      const featureNames = Object.keys(FeatureName)
+    const runmeFeatureSettings = workspace.getConfiguration('runme.features')
+    const featureNames = Object.keys(FeatureName)
 
-      featureNames.forEach((feature) => {
-        if (runmeFeatureSettings.has(feature)) {
-          const result = runmeFeatureSettings.get<boolean>(feature, false)
-          this.#featuresSettings.set(feature, result)
-        }
-      })
+    featureNames.forEach((feature) => {
+      if (runmeFeatureSettings.has(feature)) {
+        const result = runmeFeatureSettings.get<boolean>(feature, false)
+        this.#featuresSettings.set(feature, result)
+      }
+    })
 
-      this.featuresState$ = features.loadState(packageJSON, featContext, this.#featuresSettings)
+    this.featuresState$ = features.loadState(packageJSON, featContext, this.#featuresSettings)
 
-      if (this.featuresState$) {
-        const subscription = this.featuresState$
-          .pipe(map((_state) => features.getSnapshot(this.featuresState$)))
-          .subscribe((snapshot) => {
-            ContextState.addKey(FEATURES_CONTEXT_STATE_KEY, snapshot)
-            postClientMessage(this.messaging, ClientMessages.featuresUpdateAction, {
-              snapshot: snapshot,
-            })
+    if (this.featuresState$) {
+      const subscription = this.featuresState$
+        .pipe(map((_state) => features.getSnapshot(this.featuresState$)))
+        .subscribe((snapshot) => {
+          ContextState.addKey(FEATURES_CONTEXT_STATE_KEY, snapshot)
+          postClientMessage(this.messaging, ClientMessages.featuresUpdateAction, {
+            snapshot: snapshot,
           })
-
-        this.#disposables.push({
-          dispose: () => subscription.unsubscribe(),
         })
-      }
-    })
+
+      this.#disposables.push({
+        dispose: () => subscription.unsubscribe(),
+      })
+    }
   }
 
   get envProps() {