Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate does not suggest updates to k3a-embedded #79

Open
sverrehu opened this issue Oct 8, 2023 · 6 comments
Open

Renovate does not suggest updates to k3a-embedded #79

sverrehu opened this issue Oct 8, 2023 · 6 comments

Comments

@sverrehu
Copy link
Contributor

sverrehu commented Oct 8, 2023

Perhaps renovate does not understand how to handle semver 2 metadata.

@erikgb
Copy link
Member

erikgb commented Oct 8, 2023

Would it be possible to use Kafka version as a classifier in k3a-embedded?

@sverrehu
Copy link
Contributor Author

sverrehu commented Oct 9, 2023

This is what the Renovate log says in a local run:

 {
  "datasource": "maven",
  "depName": "no.shhsoft:k3a-embedded",
  "currentValue": "0.2.1+${kafka.version}",
  "fileReplacePosition": 909,
  "registryUrls": [
    "https://repo.maven.apache.org/maven2"
  ],
  "depType": "test",
  "skipReason": "version-placeholder",
  "depIndex": 2,
  "updates": []
}

Note the "skipReason": "version-placeholder". Not sure changing to classifier will solve this.

@erikgb
Copy link
Member

erikgb commented Oct 11, 2023

@sverrehu Could it make sense to publish a version of k3a-embedded without the build number (ref. SemVer), that is built with the latest version of Kafka available at the time the release was cut? I know it is not that "clean", but I think it should work quite well for us in this project.

@sverrehu
Copy link
Contributor Author

@sverrehu Could it make sense to publish a version of k3a-embedded without the build number (ref. SemVer), that is built with the latest version of Kafka available at the time the release was cut? I know it is not that "clean", but I think it should work quite well for us in this project.

I used to do that, but disabled it for the last release just because of the cleanlyness you mention.

@erikgb
Copy link
Member

erikgb commented Oct 11, 2023

@sverrehu Could it make sense to publish a version of k3a-embedded without the build number (ref. SemVer), that is built with the latest version of Kafka available at the time the release was cut? I know it is not that "clean", but I think it should work quite well for us in this project.

I used to do that, but disabled it for the last release just because of the cleanlyness you mention.

But this build number thing does not work well - that we know (e.g. this issue). A classifier was already suggested, which I think might work better from a user point of view, but.....

@sverrehu
Copy link
Contributor Author

sverrehu commented Oct 11, 2023

@sverrehu Could it make sense to publish a version of k3a-embedded without the build number (ref. SemVer), that is built with the latest version of Kafka available at the time the release was cut? I know it is not that "clean", but I think it should work quite well for us in this project.

I used to do that, but disabled it for the last release just because of the cleanlyness you mention.

But this build number thing does not work well - that we know (e.g. this issue). A classifier was already suggested, which I think might work better from a user point of view, but.....

Trying to figure out how to do a revert on GitHub. :-)

It is available on the PR, and not the commit. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants