Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init Fulu fork #6677

Merged
merged 16 commits into from
Nov 13, 2024
Merged

Init Fulu fork #6677

merged 16 commits into from
Nov 13, 2024

Conversation

agnxsh
Copy link
Contributor

@agnxsh agnxsh commented Oct 24, 2024

adds the Fulu hard fork to nimbus unstable.

Copy link

github-actions bot commented Oct 24, 2024

Unit Test Results

       12 files  ±  0    1 814 suites  ±0   55m 31s ⏱️ + 1m 9s
  5 237 tests +  5    4 889 ✔️ +  5  348 💤 ±0  0 ±0 
29 097 runs  +20  28 645 ✔️ +20  452 💤 ±0  0 ±0 

Results for commit 44531ad. ± Comparison against base commit a89ee31.

♻️ This comment has been updated with latest results.

@agnxsh agnxsh force-pushed the fulu branch 2 times, most recently from aa8c51a to abaffa1 Compare October 25, 2024 23:02
@agnxsh agnxsh marked this pull request as ready for review October 25, 2024 23:05
@tersec
Copy link
Contributor

tersec commented Oct 26, 2024

template readSszBytes*(
data: openArray[byte], val: var phase0.SignedBeaconBlock, updateRoot = true) =
readAndUpdateRoot(data, val, updateRoot)
template readSszBytes*(
data: openArray[byte], val: var phase0.TrustedSignedBeaconBlock, updateRoot = true) =
readAndUpdateRoot(data, val, updateRoot)
template readSszBytes*(
data: openArray[byte], val: var altair.SignedBeaconBlock, updateRoot = true) =
readAndUpdateRoot(data, val, updateRoot)
template readSszBytes*(
data: openArray[byte], val: var altair.TrustedSignedBeaconBlock, updateRoot = true) =
readAndUpdateRoot(data, val, updateRoot)
template readSszBytes*(
data: openArray[byte], val: var bellatrix.SignedBeaconBlock, updateRoot = true) =
readAndUpdateRoot(data, val, updateRoot)
template readSszBytes*(
data: openArray[byte], val: var bellatrix.TrustedSignedBeaconBlock, updateRoot = true) =
readAndUpdateRoot(data, val, updateRoot)
template readSszBytes*(
data: openArray[byte], val: var capella.SignedBeaconBlock, updateRoot = true) =
readAndUpdateRoot(data, val, updateRoot)
template readSszBytes*(
data: openArray[byte], val: var capella.TrustedSignedBeaconBlock, updateRoot = true) =
readAndUpdateRoot(data, val, updateRoot)
template readSszBytes*(
data: openArray[byte], val: var deneb.SignedBeaconBlock, updateRoot = true) =
readAndUpdateRoot(data, val, updateRoot)
template readSszBytes*(
data: openArray[byte], val: var deneb.TrustedSignedBeaconBlock, updateRoot = true) =
readAndUpdateRoot(data, val, updateRoot)
template readSszBytes*(
data: openArray[byte], val: var electra.SignedBeaconBlock, updateRoot = true) =
readAndUpdateRoot(data, val, updateRoot)
template readSszBytes*(
data: openArray[byte], val: var electra.TrustedSignedBeaconBlock, updateRoot = true) =
readAndUpdateRoot(data, val, updateRoot)

needs updating

@tersec
Copy link
Contributor

tersec commented Oct 26, 2024

# Can't use `ForkyHashedBeaconState`/`ForkyHashedSignedBeaconBlock` without
# creating recursive module dependency through `forks`.
func hash_tree_root*(
x: phase0.HashedBeaconState | altair.HashedBeaconState |
bellatrix.HashedBeaconState | capella.HashedBeaconState |
deneb.HashedBeaconState | electra.SignedBeaconBlock) {.
error: "HashedBeaconState should not be hashed".}
func hash_tree_root*(
x: phase0.SignedBeaconBlock | altair.SignedBeaconBlock |
bellatrix.SignedBeaconBlock | capella.SignedBeaconBlock |
deneb.SignedBeaconBlock | electra.SignedBeaconBlock) {.
error: "SignedBeaconBlock should not be hashed".}

needs updating

@tersec
Copy link
Contributor

tersec commented Oct 30, 2024

# Can't use `ForkyHashedBeaconState`/`ForkyHashedSignedBeaconBlock` without
# creating recursive module dependency through `forks`.
func hash_tree_root*(
x: phase0.HashedBeaconState | altair.HashedBeaconState |
bellatrix.HashedBeaconState | capella.HashedBeaconState |
deneb.HashedBeaconState | electra.SignedBeaconBlock) {.
error: "HashedBeaconState should not be hashed".}
func hash_tree_root*(
x: phase0.SignedBeaconBlock | altair.SignedBeaconBlock |
bellatrix.SignedBeaconBlock | capella.SignedBeaconBlock |
deneb.SignedBeaconBlock | electra.SignedBeaconBlock) {.
error: "SignedBeaconBlock should not be hashed".}

needs updating

done in a9c2e69

@agnxsh agnxsh force-pushed the fulu branch 2 times, most recently from 0a65bc5 to ff16c2f Compare October 30, 2024 14:28
@tersec
Copy link
Contributor

tersec commented Oct 30, 2024

Why does it modify nim-json-rpc, nim-serialization, and nim-web3?
2024-10-30T18:46:23,104029593+00:00

@agnxsh
Copy link
Contributor Author

agnxsh commented Oct 30, 2024

Why does it modify nim-json-rpc, nim-serialization, and nim-web3? 2024-10-30T18:46:23,104029593+00:00

will revert/fix post some more cleanups

@agnxsh agnxsh force-pushed the fulu branch 2 times, most recently from 2f6ad51 to 3240299 Compare October 30, 2024 19:25
@tersec tersec merged commit a157760 into unstable Nov 13, 2024
13 checks passed
@tersec tersec deleted the fulu branch November 13, 2024 03:29
@agnxsh
Copy link
Contributor Author

agnxsh commented Nov 13, 2024

restoring the branch for @Tomi-3-0 and group to branch out from fulu and have EPBS working on Fulu

@agnxsh agnxsh restored the fulu branch November 13, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants