Fix bug in ShapeTestUtil (apache#12287)

boxPolygon and trianglePolygon only uses minX and minY value of give XY Rectangle which results in a polygon with points in single place. With this changes, both methods generate correct polygons.
stefanvodita · Jan 24, 2024 · 1e586c9 · 1e586c9
1 parent 9ccfc30
commit 1e586c9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
@@ -67,6 +67,8 @@ Bug Fixes
 
 * GITHUB#12885: Fixed the bug that JapaneseReadingFormFilter cannot convert some hiragana to romaji. (Takuma Kuramitsu)
 
+* GITHUB#12287: Fix a bug in ShapeTestUtil. (Heemin Kim)
+
 Build
 ---------------------
 

diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/geo/ShapeTestUtil.java b/lucene/test-framework/src/java/org/apache/lucene/tests/geo/ShapeTestUtil.java
@@ -99,10 +99,10 @@ private static XYPolygon trianglePolygon(XYRectangle box) {
     final float[] polyY = new float[4];
     polyX[0] = box.minX;
     polyY[0] = box.minY;
-    polyX[1] = box.minX;
+    polyX[1] = box.maxX;
     polyY[1] = box.minY;
-    polyX[2] = box.minX;
-    polyY[2] = box.minY;
+    polyX[2] = box.maxX;
+    polyY[2] = box.maxY;
     polyX[3] = box.minX;
     polyY[3] = box.minY;
     return new XYPolygon(polyX, polyY);
@@ -142,12 +142,12 @@ private static XYPolygon boxPolygon(XYRectangle box) {
     final float[] polyY = new float[5];
     polyX[0] = box.minX;
     polyY[0] = box.minY;
-    polyX[1] = box.minX;
+    polyX[1] = box.maxX;
     polyY[1] = box.minY;
-    polyX[2] = box.minX;
-    polyY[2] = box.minY;
+    polyX[2] = box.maxX;
+    polyY[2] = box.maxY;
     polyX[3] = box.minX;
-    polyY[3] = box.minY;
+    polyY[3] = box.maxY;
     polyX[4] = box.minX;
     polyY[4] = box.minY;
     return new XYPolygon(polyX, polyY);