Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing any of the stick curves doesn't apply at all! #5

Open
GittyUser54321 opened this issue Jan 25, 2024 · 13 comments · Fixed by #9
Open

Changing any of the stick curves doesn't apply at all! #5

GittyUser54321 opened this issue Jan 25, 2024 · 13 comments · Fixed by #9
Assignees
Labels
enhancement New feature or request

Comments

@GittyUser54321
Copy link

GittyUser54321 commented Jan 25, 2024

As per title! it would be great if it was working if you could include the graphic and how it changes the curves like in ps5:

DSE sens curves

DSE settings

Oh and to take it a step further, it would be great to be able to add a custom curve not already in the presets. Similar to how DS4 does it with their BezierCurveEditor: https://github.com/gre/bezier-easing-editor/tree/master/example

@steffalon steffalon self-assigned this Feb 10, 2024
@steffalon steffalon added the enhancement New feature or request label Feb 10, 2024
@steffalon
Copy link
Owner

Hi @GittyUser54321, Thank you for your suggestion. changing the curves are fixed and will apply correctly (as you mentioned before in ticket #6).

The BezierCurveEditor is very outdated and built for React instead of Vue. Instead, I will make something from scratch. I expect to release this feature today.

@steffalon steffalon linked a pull request Feb 10, 2024 that will close this issue
@steffalon
Copy link
Owner

Let me know if this issue is fully resolved :)

@steffalon steffalon reopened this Feb 10, 2024
@GittyUser54321
Copy link
Author

Let me know if this issue is fully resolved :)

Ok thank you. So this means that you can't do custom curves? Also, what does the red lines mean on the graphic? Hoping its not the deadzones cos you can't adjust those on there (would prefer 0 anyways).

Also, not sure if you are aware and you may need to test it again but the button remapping wasn't working after the curve updates.

@steffalon
Copy link
Owner

steffalon commented Feb 11, 2024

Red line is to test your input. All to left === full stick input.

"Also, not sure if you are aware and you may need to test it again but the button remapping wasn't working after the curve updates." Mine still works? Even after changing curve values and curve type. Could you reproduce your steps?

@steffalon
Copy link
Owner

"So this means that you can't do custom curves?" it is possible however the PS5 does not allow to make custom values ouside their presets. I'm not sure how much I can customize it regarding the curve positions.

@GittyUser54321
Copy link
Author

Red line is to test your input. All to left === full stick input.

"Also, not sure if you are aware and you may need to test it again but the button remapping wasn't working after the curve updates." Mine still works? Even after changing curve values and curve type.

Yeah any button remapping doesn't work for me at the moment. Maybe its because I used DSX on steam to remap the buttons to my profiles there. But thats weird cos it shouldn't interfer with this webapp after I have closed that app off. It only started happening when the curves got fixed cos before it didn't matter if I used DSX as I could go on your webapp and still change the remappings.

@GittyUser54321
Copy link
Author

"So this means that you can't do custom curves?" it is possible however the PS5 does not allow to make custom values ouside their presets. I'm not sure how much I can customize it regarding the curve positions.

Oh ok hmmm. Thats a bummer. It would have been epic to be able to really do your own curves outside of the preset ones and save them to the controller.

@steffalon
Copy link
Owner

steffalon commented Feb 11, 2024

I could experiment setting custom values. But I do need to redesign some functions. So it might not be a quick fix.

@steffalon
Copy link
Owner

Are you able to change something on the controller using this app? Also, make sure you are using usb instead of bluetooth.

@GittyUser54321
Copy link
Author

Are you able to change something on the controller using this app? Also, make sure you are using usb instead of bluetooth.

Ok so I cleared the profile I was using and started again on this webapp and all is working as usual. Must have been a bug when using DSX along with this app.

@GittyUser54321
Copy link
Author

I could experiment setting custom values. But I do need to redesign some functions. So it might not be a quick fix.

Yeah honestly this would be amazing. Alot of games have weird curves and being able to do custom curves to counteract them would be super useful. And even just custom curves in general. Would make this app better than even the Ps5 one.

@steffalon
Copy link
Owner

steffalon commented Feb 11, 2024

I'll try fixing it in the future :) But the DSX conflicting this app is very odd. Not sure why it would not save input mappings.

@GittyUser54321
Copy link
Author

I'll try fixing it in the future :) But the DSX conflicting this app is very odd. Not sure why it would not save input mappings.

Yeah super strange bug. Thanks a lot for everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants