Fix #38 and fix compatibility with calibre-web #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Thanks! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #38 and fixes compatibility with calibre-web by making a couple checks against the feed optional. I haven't tested it super thoroughly so I don't know if any other checks need to be fixed but I added fallback values in case a feed doesn't have the "server" or "updated" keys present.
A couple tips in case anyone in the future is reading this and struggling to get calibre-web to play nicely with the plugin:
http://url-of-server/opds/booksthen select "All" in the dropdown and press Download OPDS. This grabs the full library (limits may exist, unsure) in alphabetical order.