Release/5.20.0 (#1314)

* Feature/hash signing 2 (#1303)

* flips the session store flag, updates listeners to not be intialized … (#1169)

* capture amplitude errors to better understand why they're triggering sentry (#1167)

* flips the session store flag, updates listeners to not be intialized async for v3

* updates e2e tests for manifest v3

---------

Co-authored-by: Piyal Basu <pbasu235@gmail.com>

* add scripts tag for Firefox (#1294)

* uses chrome storage in migrations instead of local storage

* checks for migrated account in migration logic to set migrated network

* don't babel-polyfill contentScript (#1297)

* don't clear all of localStore on recoverAccount (#1301)

* add hash signing option (ui and data storage)

* fix redux state update; show custom errors from hardware wallet

* Added translations

* when experimental mode is enabled, switch network

* PR comments

* rm logs

---------

Co-authored-by: aristides <aristides.staffieri@stellar.org>

* Feature/trustline sac (#1289)

* Bump axios, @docusaurus/core and @docusaurus/preset-classic in /docs (#1244)

Removes [axios](https://github.com/axios/axios). It's no longer used after updating ancestor dependencies [axios](https://github.com/axios/axios), [@docusaurus/core](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus) and [@docusaurus/preset-classic](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-preset-classic). These dependencies need to be updated together.


Removes `axios`

Updates `@docusaurus/core` from 2.4.1 to 3.2.1
- [Release notes](https://github.com/facebook/docusaurus/releases)
- [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/docusaurus/commits/v3.2.1/packages/docusaurus)

Updates `@docusaurus/preset-classic` from 2.4.1 to 3.2.1
- [Release notes](https://github.com/facebook/docusaurus/releases)
- [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/docusaurus/commits/v3.2.1/packages/docusaurus-preset-classic)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
- dependency-name: "@docusaurus/core"
  dependency-type: direct:production
- dependency-name: "@docusaurus/preset-classic"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump express from 4.18.2 to 4.19.2 in /docs (#1216)

Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Piyal Basu <pbasu235@gmail.com>

* Bump tar from 6.1.15 to 6.2.1 (#1231)

Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.15 to 6.2.1.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.1.15...v6.2.1)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Piyal Basu <pbasu235@gmail.com>

* Bump express from 4.18.2 to 4.19.2 (#1214)

Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Piyal Basu <pbasu235@gmail.com>

* Bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /docs (#1208)

Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

---
updated-dependencies:
- dependency-name: webpack-dev-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Piyal Basu <pbasu235@gmail.com>

* Bump webpack-dev-middleware from 5.3.3 to 5.3.4 (#1207)

Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

---
updated-dependencies:
- dependency-name: webpack-dev-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump follow-redirects from 1.15.4 to 1.15.6 in /docs (#1198)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Piyal Basu <pbasu235@gmail.com>

* Bump follow-redirects from 1.15.2 to 1.15.6 (#1197)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Piyal Basu <pbasu235@gmail.com>

* Bump ip from 2.0.0 to 2.0.1 (#1128)

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Piyal Basu <pbasu235@gmail.com>

* Bump axios, @docusaurus/core and @docusaurus/preset-classic in /docs (#1055)

Removes [axios](https://github.com/axios/axios). It's no longer used after updating ancestor dependencies [axios](https://github.com/axios/axios), [@docusaurus/core](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus) and [@docusaurus/preset-classic](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-preset-classic). These dependencies need to be updated together.


Removes `axios`

Updates `@docusaurus/core` from 2.4.1 to 3.0.1
- [Release notes](https://github.com/facebook/docusaurus/releases)
- [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/docusaurus/commits/v3.0.1/packages/docusaurus)

Updates `@docusaurus/preset-classic` from 2.4.1 to 3.0.1
- [Release notes](https://github.com/facebook/docusaurus/releases)
- [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/docusaurus/commits/v3.0.1/packages/docusaurus-preset-classic)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
- dependency-name: "@docusaurus/core"
  dependency-type: direct:production
- dependency-name: "@docusaurus/preset-classic"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Piyal Basu <pbasu235@gmail.com>

* first pass at adding remove dropdown

* replaces all remaining instances of wallet-sdk

* tweaks tx detail row layouts to avoid overflows

* adds getContractSpec, uses it to display parameter names in tx sign detail view

* migrates KeyManager to ts-wallet-sdk

* upgrades react and react dom types to 18

* adds react types to extension workspace, fixes type errors

* set styles for dropdown

* Added translations

* adds standalone version of getContractSpec and related helpers

* Added translations

* Added translations

* undo husky pre push comments

* Feature/p21 futurenet release (#1278)

* switch between stellar-sdk and stellar-sdk-next based on network

* increase max diff pixel ratio for playwright

* rm console

* adds tx timeout in send and swap settings

* Added translations

* tweaks tooltip text

* Added translations

* happy path for new add asset flow

* fix trustline error warning and fix naming

* Added translations

* rollback dep upgrades

* rollback changes

* rollback package-lock upgrade

* add snapshots for manage assets and send payment (#1309)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aristides Staffieri <aristides.staffieri@stellar.org>

* guard against dispatching incorrect parameter (#1305)

* adds Hardware sign usage in ReviewAuth for use during invokeHostFn signing, tweaks soroban icon to not overflow in signing details (#1282)

* adds loader for hardware signing during signing (#1284)

Co-authored-by: Piyal Basu <pbasu235@gmail.com>

* adds sign blob error for encoding mismatch (#1300)

* fix bad merge

* [BUG] replaces all instances of pickTransfer with getTokenSpec workflow (#1312)

* replaces all instances of pickTransfer with getTokenSpec workflow

* check for transfer once token spec is confirmed

* rm unused dep

* fixes bad merge from upstream in ManageAssets

* Added translations

* remove accidental mobile4 dir addition

---------

Co-authored-by: Piyal Basu <pbasu235@gmail.com>

* Test/data storage (#1304)

* adds test for data storage get item

* adds tests for network migrations

* adds test for remaining migrations

* reverts bad merge from upstream

---------

Co-authored-by: Piyal Basu <pbasu235@gmail.com>

* [CHORE] upgrades all webpack related deps (#1307)

* upgrades all webpack related deps

* updates lock file

* updates migrations test for recent changes

* [CHORE] upgrade to docusaurus v3 (#1306)

* upgrade to docusaurus v3

* edit manifest for chrome before uploading (#1315)

* use single quotes (#1316)

---------

Co-authored-by: Piyal Basu <pbasu235@gmail.com>

* Fix manage assets tests (#1317)

* fix tests for new manage assets flow

* fix broken manage-assets tests

* rm unused dep

* fix e2e tests

* fix query for visible loader

* fix assets test

* selector for individual asset balance

* add better error messaging for liabilities when removing an asset (#1319)

* add better error messaging for liabilities when removing an asset

* add tests and rm sellingLiabilities

* rm more selling liabilities

* fix diff

* fix diff again

* verify params before fetching issuer info (#1320)

* add better error messaging for liabilities when removing an asset

* add tests and rm sellingLiabilities

* rm more selling liabilities

* fix diff

* fix diff again

* verify params before fetching issuer info

* pin docusaurus core to match versions

* split dataStorageAccess into a different file to allow for jest mocks with circular deps

* updates all references for new dataStorage path

* fix add asset padding; fix ledger trustline error; fix token-spec check (#1324)

* fix add asset padding; fix ledger trustline error; fix token-spec check

* use dynamic verified token in e2e test

* undo the hw wallet trustline error fix while I figure out how to do it properly

* revert isTokenSpec change

* better trustline error handling; fix remove token (#1326)

* upgrade redux toolkit (#1333)

* upgrade redux toolkit

* allow a longer timeout to account for network congestion

* Bugfix/5.20.0 qa (#1334)

* styling and copy fixes

* Added translations

* Bugfix/5.20.0 legal copy (#1337)

* legal copy changes

* Added translations

* fix go back button

* use history.goBack for go back button

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: aristides <aristides.staffieri@stellar.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

@shared/api/helpers/getDomainFromIssuer.ts

@@ -1,3 +1,4 @@
+import { StrKey } from "stellar-sdk";
 import { getSdk } from "@shared/helpers/stellar";
 import { sendMessageToBackground } from "./extensionMessaging";
 import { SERVICE_TYPES } from "../../constants/services";
@@ -35,6 +36,9 @@ export const getDomainFromIssuer = async ({
     const Sdk = getSdk(networkPassphrase);
 
     const server = new Sdk.Horizon.Server(networkUrl);
+    if (!StrKey.isValidEd25519PublicKey(key)) {
+      return assetDomain;
+    }
     response = await server.loadAccount(key);
   } catch (e) {
     return assetDomain;

@shared/api/helpers/getIconUrlFromIssuer.ts

@@ -1,4 +1,4 @@
-import { StellarToml } from "stellar-sdk";
+import { StellarToml, StrKey } from "stellar-sdk";
 import { sendMessageToBackground } from "./extensionMessaging";
 import { stellarSdkServer } from "./stellarSdkServer";
 import { SERVICE_TYPES } from "../../constants/services";
@@ -58,6 +58,9 @@ export const getIconUrlFromIssuer = async ({
     /* Otherwise, 1. load their account from the API */
     const { networkUrl, networkPassphrase } = networkDetails;
     const server = stellarSdkServer(networkUrl, networkPassphrase);
+    if (!StrKey.isValidEd25519PublicKey(key)) {
+      return iconUrl;
+    }
 
     response = await server.loadAccount(key);
   } catch (e) {
@@ -69,7 +72,10 @@ export const getIconUrlFromIssuer = async ({
 
   try {
     /* 2. Use their domain from their API account and use it attempt to load their stellar.toml */
-    toml = await StellarToml.Resolver.resolve(homeDomain || "");
+    if (!homeDomain) {
+      return iconUrl;
+    }
+    toml = await StellarToml.Resolver.resolve(homeDomain);
   } catch (e) {
     console.error(e);
     return iconUrl;