adjust button color and fix bad merge #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
commented
Nov 5, 2024
| @@ -183,25 +180,7 @@ export const Account = () => { | |||
| setLoading={setLoading} | |||
| /> | |||
| {/* <BlockaidAnnouncement /> */} | |||
| <View.Content | |||
There was a problem hiding this comment.
this looks like it was a result of a bad merge. This button now appears in the ... dropdown on Account
There was a problem hiding this comment.
ah yup that was my mistake, thanks!
piyalbasu
commented
Nov 5, 2024
| @@ -44,7 +44,7 @@ | |||
| stroke: var(--sds-clr-base-01); | |||
| width: 1rem; | |||
| height: 1rem; | |||
| stroke: var(--sds-clr-gray-11); | |||
| stroke: var(--sds-clr-gray-12); | |||
There was a problem hiding this comment.
fixing the button color of the Send and ... buttons on Account
There was a problem hiding this comment.
Hmm gray-11 loooks like this for me 🤔
aristidesstaffieri
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing button colors to adhere to the pattern established in the Figma of using:
Some examples: