Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/safari support #929

Merged
merged 31 commits into from
Aug 26, 2024
Merged

Conversation

aristidesstaffieri
Copy link
Contributor

@aristidesstaffieri aristidesstaffieri commented Aug 4, 2023

Adds fastlane support in order to deploy to Safari from an action in CI.

Adds:

  • new action submitSafari(separate from submitProduction because we need to use a mac image for xcode
  • fastlane integration
  • safari store env vars

@aristidesstaffieri aristidesstaffieri added the wip not for merging yet label Aug 4, 2023
@aristidesstaffieri aristidesstaffieri self-assigned this Aug 4, 2023
@aristidesstaffieri aristidesstaffieri changed the base branch from master to release/5.5.0 August 31, 2023 14:49
@aristidesstaffieri aristidesstaffieri changed the base branch from release/5.5.0 to master August 31, 2023 14:53
@aristidesstaffieri aristidesstaffieri changed the title [WIP] Feature/safari support Feature/safari support Aug 31, 2023
@aristidesstaffieri aristidesstaffieri removed the wip not for merging yet label Aug 31, 2023
@aristidesstaffieri aristidesstaffieri marked this pull request as ready for review August 31, 2023 15:10
@aristidesstaffieri
Copy link
Contributor Author

Should this be based from master? It's only build related so it seems ok to me but happy to target it for a release branch also.

cleans up bad indentation and old comments
@piyalbasu
Copy link
Contributor

Should this be based from master? It's only build related so it seems ok to me but happy to target it for a release branch also.

Yup, I think master makes sense. Do you want to double check the formatting changes? The line breaks seem a little off on some of them

@aristidesstaffieri
Copy link
Contributor Author

Should this be based from master? It's only build related so it seems ok to me but happy to target it for a release branch also.

Yup, I think master makes sense. Do you want to double check the formatting changes? The line breaks seem a little off on some of them

Hmm which line? I took it into the editor that parses it and it didn't complain, I don't visually see it yet 🤔

@aristidesstaffieri
Copy link
Contributor Author

@piyalbasu we have the env vars set now, so once we are good here should I re-run the action and submit to the store for the first time?

@aristidesstaffieri aristidesstaffieri changed the base branch from master to release/5.24.0 August 26, 2024 15:58
@aristidesstaffieri aristidesstaffieri merged commit 295ece3 into release/5.24.0 Aug 26, 2024
3 checks passed
@aristidesstaffieri aristidesstaffieri deleted the feature/safari-support branch August 26, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants