Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEP-12 KYC: use field type for input #327

Merged
merged 2 commits into from
Oct 20, 2023
Merged

SEP-12 KYC: use field type for input #327

merged 2 commits into from
Oct 20, 2023

Conversation

quietbits
Copy link
Contributor

@quietbits quietbits commented Oct 20, 2023 •
edited
Loading

image

@stellar-jenkins
Copy link

Preview is available here:
http://stellar-demo-wallet-client-pr327.previews.kube001.services.stellar-ops.com/

JakeUrban
JakeUrban reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@JakeUrban JakeUrban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly we were submitting KYC via JSON, but if we have files we'll need to submit using form-data. Can you verify we have that support?

@quietbits
Copy link
Contributor Author

@JakeUrban We are submitting KYC fields as form data. It worked when I tested SEP-6 deposit/withdrawal and SEP-31, but I'm not sure if SRT validates the image input.

@JakeUrban
Copy link
Contributor

It validates and deserializes the content in the request so I think we're good then.

@quietbits quietbits merged commit f5b6e29 into master Oct 20, 2023
2 checks passed
@quietbits quietbits deleted the sep12-input-types branch October 20, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeUrban JakeUrban JakeUrban approved these changes

@piyalbasu piyalbasu Awaiting requested review from piyalbasu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quietbits @stellar-jenkins @JakeUrban