refactor: ♻️ function to create LPR2 #152
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on updates from #133
Aastedet
reviewed
Sep 27, 2024
| get_department <- function(x) { | ||
| dplyr::case_when( | ||
| # TODO: Include this in algorithm dataframe some how? | ||
| x == "08" ~ "endocrinology", |
There was a problem hiding this comment.
the real world data for some users may be weird if it's been converted from SAS format and changed to integer type in the process, so maybe we should make this piece of code robust to those sort of quirks? e.g. x == "08" | == 8?
Aastedet
reviewed
Sep 27, 2024
| # TODO: Include this in algorithm dataframe some how? | ||
| x == "08" ~ "endocrinology", | ||
| # < 8 and between 9-30 | ||
| stringr::str_detect(x, "(0[0-8]|9|[1-3][0-9])") ~ "other medical" |
There was a problem hiding this comment.
also potential for data quirks here, of course.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on updates from #133.
Since there were several clarifications made about how LPR2 is created and the variables needed, I created several functions to create the needed LPR2 dataset. Draft for now, I am not done.