Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to fake data #87

Merged
merged 4 commits into from
May 16, 2024
Merged

Minor fixes to fake data #87

merged 4 commits into from
May 16, 2024

Conversation

Aastedet
Copy link
Collaborator

Small edits to provide:
a) The correct NPU code length (8)
b) to_wwyy() a way to simulate edge cases of events that fall on isoweek 53 of a year (I think lubridate might already have handled these correctly on linux, but not on windows)
c) LPR3's diagnoser$diagnosetype now match LPR2's lpr_diag$c_diagtype (I just did a simple simulation_definitions[25,]$generator <- simulation_definitions[16,]$generator)

@Aastedet
Copy link
Collaborator Author

Small edits to provide: a) The correct NPU code length (8) b) to_wwyy() a way to simulate edge cases of events that fall on isoweek 53 of a year (I think lubridate might already have handled these correctly on linux, but not on windows) c) LPR3's diagnoser$diagnosetype now match LPR2's lpr_diag$c_diagtype (I just did a simple simulation_definitions[25,]$generator <- simulation_definitions[16,]$generator)

And I just realized c) is already taken care of in #86 (that's what I get for not reviewing PR's 😜 )

@lwjohnst86 lwjohnst86 merged commit 9fc81c4 into main May 16, 2024
@lwjohnst86 lwjohnst86 deleted the minor-fixes-to-fake-data branch May 16, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants