chore: Fix update-code.sh not generating proto files in subdirectories #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Determined which files to delete with `grep -r 'Code generated by' integration`. It also lists two go files that I'm ignoring here, they are not deleted.
stephenh
approved these changes
Jun 6, 2024
|
🎉 This PR is included in version 1.176.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with
integration/update-code.sh: There are several integration tests with proto files in subdirectories, but the script does not re-generate them. This means that it's possible to get false positives or false negatives from tests.This PR not only updates the script, it also deletes several generated files, where the proto file was removed or renamed at some point, and the generated file wasn't deleted.
It also deletes one proto file:
integration/simple-optionals/thing.protois a duplicate ofintegration/simple-optionals/import_dir/thing.proto. The latter is imported by another proto file, and compiling them together results in a compiler error (meaning that no files will be generated):I've verified that the updated script works as expected by deleting all generated files (see second commit), and re-generating them (third commit).