Do not run curl silent during plugin installation #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps to see if the plugin installation works. Also fail if it fails
stevehipwell
requested changes
Oct 14, 2024
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
|
Sure, makes sense. By the way the fail flag is fairly critical since i found at that if you boostrap a nexus that used to have a plugin for e.g. compose, and it does no longer have the plugin (failed to install), the repository will be removed and i could not find any way to 're-add' it (even using the same dedicated blob store as before). So booting once means the repo-data is wiped and the repo needs to be re-created (including it's entire contect). So it is important to 'not boot' in this case, since it could be fatal |
stevehipwell
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps to see if the plugin installation works. Also fail if it fails