CPE: Fix false negative on part comparison #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the test case may need to be updated also? |
|
Will push an updated patch to fix this :)
|
Jasper-Ben
force-pushed
the
fix_false_negative_when_component_CPE_part_is_any
branch
from
0270865
to
5b9ca5f
Compare
|
Testcases should be fixed now. I also added some comments to the code for easier understanding of the changes. |
Previously, comparing CPEs will cause false negatives, if the component (right) "part" contains an "ANY" value, while the CVE (left) contains a string value or logical value "NA". Instead, this should return a match, as defined by cases 5, 13, 15 within table 6-2 in the [NIST name matching specification](https://nvlpubs.nist.gov/nistpubs/Legacy/IR/nistir7696.pdf).
Jasper-Ben
force-pushed
the
fix_false_negative_when_component_CPE_part_is_any
branch
from
5b9ca5f
to
183ff71
Compare
|
Fixed minor typo. |
|
@Jasper-Ben Thanks for identifying and fixing the issue. |
Jasper-Ben
deleted the
fix_false_negative_when_component_CPE_part_is_any
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, comparing CPEs will cause false negatives, if the component (right) "part" contains an "ANY" value, while the CVE (left) contains a string value or logical value "NA".
Instead, this should return a match, as defined by cases 5, 13, 15 within table 6-2 in the NIST name matching specification.