-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External trigger #20
Merged
Merged
External trigger #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big branch with a number of changes focusing around the external triggering device, and adjustments to how most other adapters behave.
Issues Approached
Closes #16. It feels inarguable that, while some other minor refinements may need to be done, the camera controls are integrated. Closes #12. With no talk of the performance monitor, we can safely put that aside for now.
Closes #14. What further hardware is wanted can be discussed in future. For the purposes of the integration, this concludes it with finishing the camera work.
References #3. As with #19.
Changes Made
Too many to talk about in much detail.
+ Acquisition adapter now exists, using munir to handle acquisitions via odin data and inter-adapter-communication to link other adapters together.
+ Added external trigger and all of the relevant sourcefiles associated there. Uses same modbus mechanism as the furnace/PID PLC
~ Trigger means that there are now two platformio projects, so the existing 'livex' one has been moved up into the firmware directory
+ Image compression handling in the live_data adapter
~
liveXEndPoint
in the UI becomesfurnaceEndPoint
as the acquisition adapter steals thelivex
title~ UI tabs/pages altered. 'Metadata and Setup' is one page merging those two concepts. #19 integrates the metadata half of this.
~ camera adapter structure reworked: now tree uses camera names to define paths, instead of an array. This matches how munir handles multiple subsystems