Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External trigger #20

Merged
merged 25 commits into from
Aug 7, 2024
Merged

External trigger #20

merged 25 commits into from
Aug 7, 2024

Conversation

TeraMika
Copy link
Collaborator

@TeraMika TeraMika commented Aug 7, 2024

This is a big branch with a number of changes focusing around the external triggering device, and adjustments to how most other adapters behave.

Issues Approached

Closes #16. It feels inarguable that, while some other minor refinements may need to be done, the camera controls are integrated. Closes #12. With no talk of the performance monitor, we can safely put that aside for now.
Closes #14. What further hardware is wanted can be discussed in future. For the purposes of the integration, this concludes it with finishing the camera work.
References #3. As with #19.

Changes Made

Too many to talk about in much detail.
+ Acquisition adapter now exists, using munir to handle acquisitions via odin data and inter-adapter-communication to link other adapters together.
+ Added external trigger and all of the relevant sourcefiles associated there. Uses same modbus mechanism as the furnace/PID PLC
~ Trigger means that there are now two platformio projects, so the existing 'livex' one has been moved up into the firmware directory
+ Image compression handling in the live_data adapter
~ liveXEndPoint in the UI becomes furnaceEndPoint as the acquisition adapter steals the livex title
~ UI tabs/pages altered. 'Metadata and Setup' is one page merging those two concepts. #19 integrates the metadata half of this.
~ camera adapter structure reworked: now tree uses camera names to define paths, instead of an array. This matches how munir handles multiple subsystems

@TeraMika TeraMika merged commit fb19371 into main Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera Integration Outstanding Hardware/Controls Monitoring
1 participant