bug fix on blockbinary conversion to ieee-754

stillwater-sc · Nov 13, 2024 · da74726 · da74726
1 parent 59eedcf
commit da74726
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/include/universal/internal/blockbinary/blockbinary.hpp b/include/universal/internal/blockbinary/blockbinary.hpp
@@ -789,12 +789,11 @@ class blockbinary {
 	Real to_native() const {
 		blockbinary tmp(*this);
 		if (isneg()) tmp.twosComplement();
-		Real v{ 1.0 }, base{ 1.0 };
-		for (unsigned i = 0; i < nbits - 1; ++i) {
-			if (tmp.test(i)) v *= base;
+		Real v{ 0.0 }, base{ 1.0 };
+		for (unsigned i = 0; i < nbits; ++i) {
+			if (tmp.test(i)) v += base;
 			base *= 2.0;
 		}
-
 		return (isneg() ? -v : v);
 	}
 	// determine the rounding mode: result needs to be rounded up if true

diff --git a/static/rational/conversion/assignment.cpp b/static/rational/conversion/assignment.cpp
@@ -112,14 +112,15 @@ try {
 
 #if MANUAL_TESTING
 
-	rb8 a,b;
+	rb64 a,b;
 	a.set(0x02, 0x0A);
+	std::cout << to_binary(a) << '\n';
 	double da = double(a);
 	b = da;
+	std::cout << to_binary(da) << " : " << da << '\n';
 	std::cout << a << '\n';
 	std::cout << b << '\n';
 
-	return 0;
 	Ranges(1.0f);
 
 	// manual exhaustive test