Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping a docker image necessitates failing CI before merge #189

Open
a-frantz opened this issue Nov 26, 2024 · 2 comments
Open

bumping a docker image necessitates failing CI before merge #189

a-frantz opened this issue Nov 26, 2024 · 2 comments

Comments

@a-frantz
Copy link
Member

The process for bumping any of our built docker images involves testing them using a branch-* specific image that is built as part of our CI. While testing using these images, the lint-check.yaml CI will fail because the tag isn't a valid production value.

We don't want to build the production-ready image as part of branch development, but to get the lint-check CI passing we have to reference tags that don't exist yet. So at least the last commit on a PR that bumps one of these docker images is going to be pointing at a non-existent tag (so the pytest tests will fail).

Is there a way we can re architect our CI so that the last commit can be green?

@a-frantz
Copy link
Member Author

Check this comment for a breakdown of what happened to the CI in a recent PR - #187 (comment)

@a-frantz
Copy link
Member Author

@adthrasher

I think you can write an action that runs on merge and you could simply add another commit that deletes the branch-* portion of the container entries.
Another option would be to append a step to the docker image builds that updates the tags in the WDL files to whatever was just built.

Andrew Frantz

Both of those sound possible. The first option would probably use a lot of logic we would need for deleting the branch-* images, which we currently don't do. I'm surprised we haven't run into issues with ghcr.io with how many tags we throw up there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant