You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The process for bumping any of our built docker images involves testing them using a branch-* specific image that is built as part of our CI. While testing using these images, the lint-check.yaml CI will fail because the tag isn't a valid production value.
We don't want to build the production-ready image as part of branch development, but to get the lint-check CI passing we have to reference tags that don't exist yet. So at least the last commit on a PR that bumps one of these docker images is going to be pointing at a non-existent tag (so the pytest tests will fail).
Is there a way we can re architect our CI so that the last commit can be green?
The text was updated successfully, but these errors were encountered:
I think you can write an action that runs on merge and you could simply add another commit that deletes the branch-* portion of the container entries.
Another option would be to append a step to the docker image builds that updates the tags in the WDL files to whatever was just built.
Andrew Frantz
Both of those sound possible. The first option would probably use a lot of logic we would need for deleting the branch-* images, which we currently don't do. I'm surprised we haven't run into issues with ghcr.io with how many tags we throw up there.
The process for bumping any of our built docker images involves testing them using a
branch-*
specific image that is built as part of our CI. While testing using these images, thelint-check.yaml
CI will fail because the tag isn't a valid production value.We don't want to build the production-ready image as part of branch development, but to get the
lint-check
CI passing we have to reference tags that don't exist yet. So at least the last commit on a PR that bumps one of these docker images is going to be pointing at a non-existent tag (so thepytest
tests will fail).Is there a way we can re architect our CI so that the last commit can be green?
The text was updated successfully, but these errors were encountered: