-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: full task compliance with style-guide #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adthrasher
approved these changes
Sep 5, 2023
Co-authored-by: Andrew Thrasher <adthrasher@gmail.com>
* main: feat: endedness and ngsderive update (#108) chore(fqlint): bump mem... again chore(fqlint): teensy tiny mem bump
New repository rule! Beginning with this PR, ALL tasks must be covered by at least one test and all tests must be passing (unless there's good reason for a test to be failing). No CI has been implemented yet, so we're relying on ad-hoc testing and self-reporting of success. I have added tests that were missing, and have gotten everything passing. EXCEPT:
|
adthrasher
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe all task meta/parameter meta should be fully spec compliant now. Except the
ngsderive
file which is being handled in #108 . If any tasks are noticed with non-compliant meta sections, please bring to my attention. (Sure would be nice to have a tool that would verify this for us)And a new style rule! All "deprecated" tasks should be at the bottom of the file. I figure that's an uncontroversial rule.
While working through this, I also made some updates to tasks, mainly exposing more parameters in
samtools.wdl
.Also set a new soft limit for "least amount of memory to allocate a task", which is 4gb. Implementing this meant lowering a few tasks' default allocation from 5gb to 4gb for consistency. No allocations were raised (as none were less than 4).
Still TODO in other PRs:
outputs
section will be easier to write now, as we can just copy+paste from the taskoutputs
sectionsTODO
comments that I didn't feel like addressing at the time. They can be dealt with in another PR