Update tooling and and add nix #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add gh action
gampleman
approved these changes
Oct 20, 2023
| @@ -0,0 +1,33 @@ | |||
| npm-install: | |||
There was a problem hiding this comment.
Generally speaking it's a good idea to declare these as .PHONY in a makefile, you can skip errors when a file called test is accidentally created your tests won't run.
bin/cli.js
Outdated
| if (typeof arg === "string") return arg.split(" "); | ||
| return []; | ||
| }) | ||
| .default("elm-test-args", []).argv; | ||
|
|
||
| var model = runner.init(argv); | ||
|
|
||
| runner.run(model, function(warnings) { | ||
| runner.run(model, function (warnings) { | ||
| console.log("warnings", warnings); |
There was a problem hiding this comment.
Suggested change
| console.log("warnings", warnings); | |
| console.warn("warnings", warnings); |
AFAIK it goes to stderr in node, which is probably more desirable.
| if (err) { | ||
| mkdirp(testsDocModulePath) | ||
| .then(function () { | ||
| fs.writeFile( |
There was a problem hiding this comment.
Might be easier to eventually rewrite this in async/await style, but that's perhaps for another PR...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds nix, make and gh-action to run tests:
To develop use:
nix develop --command make watch