no config #110
no config #110
Conversation
Co-authored-by: Johannes Emerich <johannes@emerich.de>
Co-authored-by: Jakub Hampl <kopomir@gmail.com>
|
This is awesome! What do you think about making |
I actually wonder about just removing |
|
🤷 I kind of like 'exposed-modules', but I also like simplicity... and chances are it's not going to be that big of a difference in the vast majority of cases. |
|
@knuton any feedback before I merge and release? |
|
|
||
| try { | ||
| verifyExamples = require(configPath); | ||
| if (verifyExamples["root"] !== undefined) { | ||
| throw new Error( | ||
| "elm-verify-examples.json: 'root' is no longer a valid key. It defaults to point one directory up from `/tests`." |
There was a problem hiding this comment.
Maybe I misunderstand, but I think this error will just be swallowed by the catch block?
There was a problem hiding this comment.
you are totally correct.
There was a problem hiding this comment.
I'm not sure if we should even keep this. It's a major bump and mentioned in the CHANGELOG. What do you think?
There was a problem hiding this comment.
I think it would be OK to skip it. Migration is easy enough.
Otherwise, just inform of superfluous config via console.warn? The tool is most likely going to work if a root is given, but it's a nice courtesy to inform that the config is (1) being ignored, (2) no longer needed.
|
closes #67 |
closes #109
What changes?
elm-verify-examples.jsonoptionalallfilesrootsource-directories.