-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to upstream v2.12.0 #54
Upgrade to upstream v2.12.0 #54
Conversation
6981e9c
to
83223a8
Compare
83223a8
to
29fb1c7
Compare
/test test |
29fb1c7
to
42a5b53
Compare
Signed-off-by: Subbarao Meduri <smeduri@redhat.com>
42a5b53
to
fe3ee14
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
spec: | ||
automountServiceAccountToken: true |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods Medium
app.kubernetes.io/name: kube-state-metrics | ||
app.kubernetes.io/version: 2.12.0 | ||
spec: | ||
automountServiceAccountToken: true |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods Medium
app.kubernetes.io/name: kube-state-metrics | ||
app.kubernetes.io/version: 2.12.0 | ||
spec: | ||
automountServiceAccountToken: true |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods Medium
app.kubernetes.io/name: kube-state-metrics-shard | ||
app.kubernetes.io/version: 2.12.0 | ||
spec: | ||
automountServiceAccountToken: true |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods Medium
spec: | ||
automountServiceAccountToken: true |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods Medium
@subbarao-meduri: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglascamata, subbarao-meduri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d217806
into
stolostron:release-2.11
Part of ACM-1736
ACM Support of Kubernetes versions here
ci/prow/sonar-pre-submit
ideally should be fixed in upstream fork. Ignoring the job failure.continuous-integration / ci-benchmark-tests
is expected to fail because both upstream and stolostron name the releases branchesrelease-x.y
format, while the contents are entirely different. The stolostron release branching names are currently aligned with ACM releases, and there is norelease-2.12
branch yet. Ignoring the job failure.