Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to upstream v2.12.0 #54

Merged

Conversation

subbarao-meduri
Copy link

@subbarao-meduri subbarao-meduri commented May 21, 2024

Part of ACM-1736

ACM Support of Kubernetes versions here

  1. Issues identified by the CI Job ci/prow/sonar-pre-submit ideally should be fixed in upstream fork. Ignoring the job failure.
  2. CI job continuous-integration / ci-benchmark-tests is expected to fail because both upstream and stolostron name the releases branches release-x.y format, while the contents are entirely different. The stolostron release branching names are currently aligned with ACM releases, and there is no release-2.12 branch yet. Ignoring the job failure.

@subbarao-meduri
Copy link
Author

/test test

Signed-off-by: Subbarao Meduri <smeduri@redhat.com>
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

spec:
automountServiceAccountToken: true

Check warning

Code scanning / SonarCloud

Service account tokens should not be mounted in pods Medium

Set automountServiceAccountToken to false for this specification of kind StatefulSet. See more on SonarCloud
app.kubernetes.io/name: kube-state-metrics
app.kubernetes.io/version: 2.12.0
spec:
automountServiceAccountToken: true

Check warning

Code scanning / SonarCloud

Service account tokens should not be mounted in pods Medium

Set automountServiceAccountToken to false for this specification of kind Deployment. See more on SonarCloud
app.kubernetes.io/name: kube-state-metrics
app.kubernetes.io/version: 2.12.0
spec:
automountServiceAccountToken: true

Check warning

Code scanning / SonarCloud

Service account tokens should not be mounted in pods Medium

Set automountServiceAccountToken to false for this specification of kind Deployment. See more on SonarCloud
app.kubernetes.io/name: kube-state-metrics-shard
app.kubernetes.io/version: 2.12.0
spec:
automountServiceAccountToken: true

Check warning

Code scanning / SonarCloud

Service account tokens should not be mounted in pods Medium

Set automountServiceAccountToken to false for this specification of kind DaemonSet. See more on SonarCloud
spec:
automountServiceAccountToken: true

Check warning

Code scanning / SonarCloud

Service account tokens should not be mounted in pods Medium

Set automountServiceAccountToken to false for this specification of kind Deployment. See more on SonarCloud
Copy link

openshift-ci bot commented May 21, 2024

@subbarao-meduri: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonar-pre-submit fe3ee14 link true /test sonar-pre-submit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@subbarao-meduri subbarao-meduri changed the title upgrade kube-state-metrics to v2.12.0 Upgrade to v2.12.0 May 21, 2024
@subbarao-meduri subbarao-meduri changed the title Upgrade to v2.12.0 Upgrade to upstream v2.12.0 May 21, 2024
Copy link

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglascamata, subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [douglascamata,subbarao-meduri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subbarao-meduri subbarao-meduri merged commit d217806 into stolostron:release-2.11 May 23, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants