Skip to content

Commit

Permalink
Grafana-dev test: Use default dashboard
Browse files Browse the repository at this point in the history
Previously, the grafana-dev test would create a new custom dashboard,
and test the exporting to configmap using that. However since adding
custom dashboards are not so reliable after Grafana 11 update, we change
the test to use of the default dashboards. This should improve test
reliability, and there are no difference whether we export a custom
dashboard or a default one.

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
  • Loading branch information
jacobbaungard committed Oct 8, 2024
1 parent 036178d commit 12a89cf
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions tests/grafana-dev-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ base_dir="$(
cd "$base_dir"
obs_namespace=open-cluster-management-observability

# create a dashboard for test export grafana dashboard
kubectl apply -n "$obs_namespace" -f "$base_dir"/examples/dashboards/sample_custom_dashboard/custom-sample-dashboard.yaml

# test deploy grafana-dev
cd $base_dir/tools
./setup-grafana-dev.sh --deploy
Expand Down Expand Up @@ -63,7 +60,7 @@ fi
n=0
until [ "$n" -ge 10 ]; do
# test export grafana dashboard
./generate-dashboard-configmap-yaml.sh "Sample Dashboard for E2E"
./generate-dashboard-configmap-yaml.sh "ACM - Clusters Overview"
if [ $? -eq 0 ]; then
break
fi
Expand Down

0 comments on commit 12a89cf

Please sign in to comment.