Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-14176]: Ensure CMO ConfigMap is reconciled on any event #1612

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

philipgough
Copy link
Contributor

@philipgough philipgough commented Sep 10, 2024

Backport of #1610

  1. Adds an integration test for merging of CMO ConfigMap with other clients
  2. Adds the Delete event to the Watch for CMO ConfigMap
  3. Explicitly adds the CMO ConfigMap reference to the filtered cache

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
…lertmanagersConfig

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
@philipgough
Copy link
Contributor Author

/test test-e2e

@philipgough
Copy link
Contributor Author

/retest-required

@philipgough
Copy link
Contributor Author

/test test-e2e

@coleenquadros
Copy link
Contributor

/retest

1 similar comment
@philipgough
Copy link
Contributor Author

/retest

Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

openshift-ci bot commented Sep 10, 2024

@philipgough: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 4acde49 link false /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@thibaultmg thibaultmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipgough, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [philipgough,thibaultmg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@philipgough philipgough merged commit cfe8ba6 into stolostron:release-2.11 Sep 11, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants