Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing metrics to allowlist #1649

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Add missing metrics to allowlist #1649

merged 2 commits into from
Oct 24, 2024

Conversation

sradco
Copy link
Contributor

@sradco sradco commented Oct 9, 2024

Added missing metrics to allowlist
for OpenShift Virtualization dashboards.

Signed-off-by: Shirly Radco sradco@redhat.com

@sradco
Add missing metrics to allowlist
a55d058 
Added missing metrics to allowlist
for OpenShift Virtualization dashboards.

Signed-off-by: Shirly Radco <sradco@redhat.com>
@sradco
Copy link
Contributor Author

sradco commented Oct 9, 2024

@moadz Hi, Our QE found that some panels were not showing data and I see we are missing some metrics in the allowlist unfortunately. Please review.

moadz
moadz approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@moadz moadz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@moadz
Copy link
Contributor

moadz commented Oct 16, 2024

/retest

@sradco
Copy link
Contributor Author

sradco commented Oct 16, 2024

@moadz Hi, I see this is still jot merged. It's important since without it we will not be able to view some of the panels.

@openshift-ci openshift-ci bot removed the lgtm label Oct 24, 2024
@moadz
Copy link
Contributor

moadz commented Oct 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 24, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@moadz
Copy link
Contributor

moadz commented Oct 24, 2024

/retest

1 similar comment
@moadz
Copy link
Contributor

moadz commented Oct 24, 2024

/retest

@moadz
Copy link
Contributor

moadz commented Oct 24, 2024

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadz, sradco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9715c0b into stolostron:main Oct 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadz moadz moadz approved these changes

Assignees

@moadz moadz

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sradco @moadz