-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prom operator to v0.73.2 #39
Update prom operator to v0.73.2 #39
Conversation
chore: use ptr.To()
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.17.0 to 1.18.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.17.0...v1.18.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…dependabot/go_modules/github.com/prometheus/client_golang-1.18.0 build(deps): bump github.com/prometheus/client_golang from 1.17.0 to 1.18.0
…date-status-metrics feat: add metrics tracking status updates
…#6191) Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
…rator#6192) --------- Co-authored-by: Herve Nicol <12008875+hervenicol@users.noreply.github.com>
From a comment while reviewing prometheus-operator#6153. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
…-gen-scrapeconfig chore: refactor generateScrapeConfig()
Bumps [github.com/prometheus-community/prom-label-proxy](https://github.com/prometheus-community/prom-label-proxy) from 0.7.0 to 0.8.0. - [Release notes](https://github.com/prometheus-community/prom-label-proxy/releases) - [Changelog](https://github.com/prometheus-community/prom-label-proxy/blob/main/CHANGELOG.md) - [Commits](prometheus-community/prom-label-proxy@v0.7.0...v0.8.0) --- updated-dependencies: - dependency-name: github.com/prometheus-community/prom-label-proxy dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…dependabot/go_modules/github.com/prometheus-community/prom-label-proxy-0.8.0 build(deps): bump github.com/prometheus-community/prom-label-proxy from 0.7.0 to 0.8.0
PR prometheus-operator#6001 updated the `go.mod` file under `pkg/apis/monitoring` to depend on `github.com/prometheus-operator/prometheus-operator` which isn't desired: the goal is that external projects can import `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` pulling as few dependencies as possible. This commit removes the unneeded dependency by moving the validation function to the `pkg/prometheus` directory. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
…is-gomod chore: fix pkg/apis/monitoring/go.mod
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.5.0 to 0.6.0. - [Commits](golang/sync@v0.5.0...v0.6.0) --- updated-dependencies: - dependency-name: golang.org/x/sync dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…dependabot/go_modules/golang.org/x/sync-0.6.0 build(deps): bump golang.org/x/sync from 0.5.0 to 0.6.0
* Add proposal for automated sharding Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> * Update Documentation/proposals/202310-shard-autoscaling.md * Update Documentation/proposals/202310-shard-autoscaling.md * Update Documentation/proposals/202310-shard-autoscaling.md * Update Documentation/proposals/202310-shard-autoscaling.md * Update Documentation/proposals/202310-shard-autoscaling.md * Update Documentation/proposals/202310-shard-autoscaling.md --------- Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> Co-authored-by: Simon Pasquier <spasquie@redhat.com>
This commit reorganizes the code makinguse of `SharedSecret` to reduce duplication. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
…or-tls-assets chore: refactor ShardedSecret
* Add testing guidelines Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> * Add separate Makefile targets for e2e-tests Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> * Apply suggestions from code review Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> Co-authored-by: Simon Pasquier <spasquie@redhat.com> --------- Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> Co-authored-by: Simon Pasquier <spasquie@redhat.com>
* Ensure all comments end with a period. By enabling the godot linter Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> * Fix godot issues Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> --------- Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
* Prevent mistakes with testify By enabling testifylint Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> * Fix testifylint issues Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> --------- Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
* Prevent unnecessary type conversions By enabling the unconvert linter Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> * Fix unconvert issues Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> --------- Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.19.0 to 0.20.0. - [Commits](golang/net@v0.19.0...v0.20.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…dependabot/go_modules/golang.org/x/net-0.20.0 build(deps): bump golang.org/x/net from 0.19.0 to 0.20.0
Based on github's new issue template form https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
* feat: emit events for invalid configurations Emit events when the controller rejects a resource, owing to an invalid configuration. Fixes: prometheus-operator#3611 Signed-off-by: Pranshu Srivastava <rexagod@gmail.com> * Decouple event recorder from operator metrics Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> * Only emit events if permissions were given Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> * Keep operator name consistent across telemetry Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> * Address comments Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> --------- Signed-off-by: Pranshu Srivastava <rexagod@gmail.com> Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> Co-authored-by: Pranshu Srivastava <rexagod@gmail.com>
…sic auth with prometheus/alertmanager webConfigFile (prometheus-operator#6194) * support the operator make use of the config-reloader tls and basic authentication --------- Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
…tor#5962) * Add scale subresource to Prometheus/PrometheusAgent Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> * Add retry mechanism when updating Status subresource The goal is to allow the new Prometheus-Operator version to run even with outdated CRDs. It will try to update the Status subresource and also Scale subresource. If it fails, it will retry but without Scale-related fields. Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> * Create function to generate selector labels Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> * Add UpdateScale and GetScale methods (prometheus-operator#6197) Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com> --------- Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
The Kubernetes API conventions say: > All letters in the acronym should have the same case, using the > appropriate case for the situation. Since no release includes the field yet, it's ok to change the name. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
…tp2-fieldname chore: fix field name to comply with conventions
…perator#6178) * feat: add support for remaining fields in Kubernetes SD Fixes prometheus-operator#6087 --------- Signed-off-by: Jayapriya Pai <slashpai9@gmail.com> Co-authored-by: Simon Pasquier <spasquie@redhat.com>
…http-client' flag (prometheus-operator#6448) * feat: added a check to determine if thanos support the '--prometheus.http-client' flag
…rometheus-operator#6351) * operator cmd: check if controllers' crds are supplied Only start each controller when its crd is provided, and fail the operator if no controllers start. Fixes prometheus-operator#6140 * Nit * Resolve reviews
…_sd_copy feat: add support for Docker SD in ScrapeConfig
…rator#6177) chore: test added rfac: kubernetes sd role chore: cofig.Role to lowercase rfac: unit_test role_consts
If a user specify a non-parsable proxyUrl it was not validated/rejected but will break reloading and restarting of Prometheus due to possible invalid syntax. This commit adds validation and rejects the invalid ones Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
…lidation fix: add proxyURL validation for smon,pmon and probe
…ator#6436) * ScrapeConfig CRD: add HetznerSDConfig API definition & include it under ScrapeConfig spec
Signed-off-by: dongjiang1989 <dongjiang1989@126.com> Co-authored-by: Jayapriya Pai <slashpai9@gmail.com>
chore: Add checks for selectors in KubernetesSDConfig (prometheus-operator#6177)
Allow empty separator in relabel config. This is corresponding to Prometheus' relabel config. Fixes prometheus-operator#5003
Allow empty separator in relabel config
Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
chore: cut v0.73.0
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
fix: log deprecated bearer token fields at debug level
Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
chore: cut v0.73.1
controller-runtime also calls `metrics.Register()` during init and this function can be called only once. To ensure that the k8s client metrics get updated, the global variables need to be set again by the operator. https://github.com/kubernetes-sigs/controller-runtime/blob/67b27f27e514bd9ac4cf9a2d84dec089ece95bf7/pkg/metrics/client_go_adapter.go#L42-L55 https://github.com/kubernetes/client-go/blob/aa7909e7d7c0661792ba21b9e882f3cd6ad0ce53/tools/metrics/metrics.go#L129-L170 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
…#6507) Signed-off-by: Simon Pasquier <spasquie@redhat.com>
…-pick-6507 fix: ScrapeClass TLSConfig nil pointer exception (prometheus-operator#6507)
fix: register k8s metrics
Signed-off-by: Jayapriya Pai <slashpai9@gmail.com> Co-authored-by: Simon Pasquier <spasquie@redhat.com>
chore:cut v0.73.2
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: coleenquadros The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
/retest |
@coleenquadros: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/ACM-1782