Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous fix works for Chrome but not for Safari. #2729

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Previous fix works for Chrome but not for Safari. #2729

merged 3 commits into from
Oct 28, 2024

Conversation

SB-venkatyadavilli
Copy link
Contributor

@SB-venkatyadavilli SB-venkatyadavilli commented Oct 25, 2024 •
edited
Loading

Addressed

STOP-979

Description

The previous fix works for Chrome but not for Safari.

Artifacts

image
Screen.Recording.2024-10-28.at.4.29.55.PM.mov

@SB-venkatyadavilli SB-venkatyadavilli requested a review from a team as a code owner October 25, 2024 15:06
@SB-venkatyadavilli SB-venkatyadavilli marked this pull request as draft October 25, 2024 15:06
@netlify Netlify
Copy link

netlify bot commented Oct 25, 2024 •
edited
Loading

✅ Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit 9fabe1f
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements/deploys/671f6995e96151000869e28f
😎 Deploy Preview https://deploy-preview-2729--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 25, 2024 •
edited
Loading

✅ Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit 9fabe1f
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements-demo/deploys/671f6995b02ccb0008cdf4e8
😎 Deploy Preview https://deploy-preview-2729--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bhaskarsontakke
Copy link

@SB-venkatyadavilli Please provide the details description

@SB-venkatyadavilli SB-venkatyadavilli changed the title fix: copy paste URL fix: resolve copy paste URL issue in Safari browser Oct 25, 2024
@SB-venkatyadavilli SB-venkatyadavilli changed the title fix: resolve copy paste URL issue in Safari browser The previous fix works for Chrome but not for Safari. Oct 25, 2024
@SB-venkatyadavilli SB-venkatyadavilli changed the title The previous fix works for Chrome but not for Safari. Previous fix works for Chrome but not for Safari. Oct 25, 2024
@bhaskarsontakke bhaskarsontakke marked this pull request as ready for review October 27, 2024 16:39
@SB-venkatyadavilli SB-venkatyadavilli merged commit 04fc515 into main Oct 28, 2024
7 checks passed
@SB-venkatyadavilli SB-venkatyadavilli deleted the fix/979 branch October 28, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SB-akshaythakar SB-akshaythakar SB-akshaythakar approved these changes

@ben-smartbear ben-smartbear ben-smartbear approved these changes

@bhaskarsontakke bhaskarsontakke bhaskarsontakke approved these changes

@Relionnn Relionnn Awaiting requested review from Relionnn Relionnn is a code owner automatically assigned from stoplightio/elements-owners

@prafullaAtSB prafullaAtSB Awaiting requested review from prafullaAtSB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SB-venkatyadavilli @bhaskarsontakke @ben-smartbear @SB-akshaythakar