Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(schema): swallow ajv missing reference #1147

Merged
merged 5 commits into from
May 19, 2020
Merged

chore(schema): swallow ajv missing reference #1147

merged 5 commits into from
May 19, 2020

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented May 7, 2020 •
edited
Loading

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Additional context

See comment in the code for the reasoning behind the change.

@P0lip P0lip added the t/bug Something isn't working label May 7, 2020
@P0lip P0lip self-assigned this May 7, 2020
@P0lip P0lip force-pushed the fix/ignore-ref-errors-schema branch from 2a0f080 to 3272d6e Compare May 8, 2020 23:01
@P0lip P0lip force-pushed the fix/ignore-ref-errors-schema branch from 3272d6e to 258837f Compare May 14, 2020 15:28
@P0lip P0lip marked this pull request as ready for review May 14, 2020 22:01
@P0lip P0lip requested a review from nulltoken May 14, 2020 22:01
@P0lip P0lip changed the title fix(schema): configure missingRefs fix(schema): handle missing references more gracefully May 14, 2020
nulltoken
nulltoken reviewed May 18, 2020
View reviewed changes
src/types/function.ts Outdated Show resolved Hide resolved
test-harness/scenarios/exceptions.circular.reference.oas3.scenario Show resolved Hide resolved
src/__tests__/linter.test.ts Outdated Show resolved Hide resolved
@P0lip P0lip added this to the 2020-05-13 milestone May 18, 2020
@P0lip P0lip changed the title fix(schema): handle missing references more gracefully chore(schema): swallow ajv missing reference May 19, 2020
@P0lip P0lip requested a review from nulltoken May 19, 2020 12:45
@P0lip P0lip merged commit fccd402 into develop May 19, 2020
@P0lip P0lip deleted the fix/ignore-ref-errors-schema branch May 19, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nulltoken nulltoken nulltoken approved these changes

Assignees

@P0lip P0lip

Labels
t/bug Something isn't working
Projects
None yet
Milestone
2020-05-13
Development

Successfully merging this pull request may close these issues.
2 participants
@P0lip @nulltoken