Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Teach isOpenApivX() to be a bit more strict #976

Closed
wants to merge 1 commit into from
Closed

fix: Teach isOpenApivX() to be a bit more strict #976

wants to merge 1 commit into from

Conversation

nulltoken
Copy link
Contributor

Discovered while working on #974

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@nulltoken nulltoken requested a review from P0lip February 20, 2020 07:29
P0lip
P0lip reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this is on purpose to be aligned with the studio spec detection, which is more lenient. :sad:

@nulltoken
Copy link
Contributor Author

Unfortunately this is on purpose to be aligned with the studio spec detection, which is more lenient. :sad:

Ok. Closing then.

@nulltoken nulltoken closed this Feb 25, 2020
@nulltoken nulltoken deleted the ntk/isOpenApi branch February 25, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P0lip P0lip P0lip left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nulltoken @P0lip