feat: migrations #101
Merged
feat: migrations #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
had a problem deploying
to
preview-101/merge
GitHub Actions
Failure
Website preview 🔗✨ |
hannahhoward
reviewed
Jul 2, 2024
There was a problem hiding this comment.
My first thought off the bat:
- this PR appears to copy and/or rewrite large parts of migrate to W3up, which should be publishable as an NPM package and useable here, especially in it's refactored form.
- it's fine to merge for prod use but I'd like to immediately follow on with making whatever changes are needed to remove the extra "lib" folder (other than maybe the storage tool) so that we don't have code in two places.
|
ACK yes I should have said. This is based on the migrate to w3up code but there were substantial changes I needed to do to get it working and it was easier to do them here. |
alanshaw
pushed a commit
that referenced
this pull request
Jul 2, 2024
🤖 I have created a release *beep* *boop* --- ## [1.8.0](w3console-v1.7.0...w3console-v1.8.0) (2024-07-02) ### Features * migrations ([#101](#101)) ([4f6068e](4f6068e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtu.be/jihgVtUBYg0?si=b_GfyHxJ6xq81EvI