feat: surface migration failures #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Website preview 🔗✨ |
|
Going to get this merged and deployed ASAP since we're currently smothering errors and folks may think a migration has completed successfuly when it hasn't. |
alanshaw
pushed a commit
that referenced
this pull request
Jul 3, 2024
🤖 I have created a release *beep* *boop* --- ## [1.9.0](w3console-v1.8.2...w3console-v1.9.0) (2024-07-03) ### Features * surface migration failures ([#105](#105)) ([2f552ed](2f552ed)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
LGTM anyway, albeit late |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR surfaces details of uploads that failed to migrate, adding a list of root CIDs that need to be migrated manually, accompanied with a copy button allowing the user to copy the list of failures to the clipboard:
Amongst some other visual tweaks and fixes it also fixes the remove button to appear less friendly (and not popup a confirmation modal) when the migration has been completed:
Hover state: