Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Underscore Suffix from Registration Events #205

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

kingster-will
Copy link
Contributor

@kingster-will kingster-will commented Nov 29, 2023

The changes are in line with our ongoing efforts to adhere to practices for naming conventions. Previously, registration events still had an underscore suffix. This has been removed in this RP.

Closes #209

Copy link
Member

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeoHChen LeoHChen merged commit 7e06fd7 into storyprotocol:dev Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants