fix(grouping): deploy royalty vault for member IPs without existing vaults #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
sebsadface
force-pushed
the
fix-grouping
branch
from
48e849f
to
3f46666
Compare
kingster-will
approved these changes
Oct 22, 2024
sebsadface
added a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently, the core protocol lacks a function to manually trigger royalty vault deployment. This leads to an issue in the
collectRoyaltiesAndClaimRewardfunction, where a member IP may not have a royalty vault if no license token has been minted or no derivative has been registered.Description
This PR addresses the issue by adding a workaround in the
collectRoyaltiesAndClaimRewardfunction. It now checks whether the given member IP already has a royalty vault deployed, and if not, it mints a license token for that IP to trigger the royalty vault deployment.Key Changes
GroupIdtoGroupIpIdincollectRoyaltiesAndClaimReward