Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(story-nft): implement IP metadata setting during mint #113

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

sebsadface
Copy link
Member

Description

This PR introduces the ability to set IP metadata during the minting process for OrgNFT and BaseStoryNFT. It ensures that when a new IP is registered, its metadata is provided by the user and set through CoreMetadataModule.

Key Changes

  • Integrated logic for setting IP metadata into the internal _mintAndRegisterIp function in both BaseStoryNFT and OrgNFT.
  • Added three storage variables to StorageBadgeNFT for storing IP metadata, which will be initialized during deployment. The same metadata will be the same across all badges in the collection.
  • Updated mint functions in OrgNFT to accept the IPMetadata struct defined in WorkflowStructs.
  • Updated OrgStoryNFTFactory deployment functions to accept the IPMetadata struct and pass it during the minting of OrgNFTs.

Test Plan

Added calls to assertMetadata to verify that IP metadata is correctly set for IPs minted from OrgNFT and StoryBadgeNFT. All existing tests pass locally.

@sebsadface sebsadface merged commit f9f992c into storyprotocol:main Nov 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants