Skip to content

Commit

Permalink
nullify the base config in the applicable examples (#18)
Browse files Browse the repository at this point in the history
**Description** <Describe what changed.>
This PR nullifies the baseConfig in the applicable examples. The current
example falsely shows an empty object for the `baseConfig`, which is
incorrect when we want to nullify them.

**Testing** <Describe how you tested the change.>
Tested locally3

**Documentation** <Describe any documentation that was added.>
N/A
  • Loading branch information
gramidt authored Aug 22, 2023
1 parent 68405fd commit b05c13d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/orchestrator/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type: application
# This is the chart version. This version number should be incremented each time we
# make changes to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.5
version: 0.1.6

# This is the version number of the application being deployed. This version number
# should be incremented each time we make changes to the application. Versions are
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ replicaCount: 1
orchestrator:
# We explicitly set the baseConfig to empty, so that the baseConfig will not be
# used.
baseConfig: {}
baseConfig: null
customConfig:
version: 0.0.1

Expand Down

0 comments on commit b05c13d

Please sign in to comment.