Merge pull request #3386 from mulkieran/version-3.5.8

Version 3.5.8
stratis-storage · Jul 27, 2023 · df6f424 · df6f424
2 parents 8ed94ea + 83d2af0
commit df6f424
Show file tree

Hide file tree

Showing 33 changed files with 539 additions and 457 deletions.
diff --git a/.github/workflows/cargo.yml b/.github/workflows/cargo.yml
@@ -51,7 +51,7 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         with:
           components: cargo
-          toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+          toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
       - name: Check out ci repo
         run: git clone https://github.com/stratis-storage/ci.git
       - name: Run comparisons of version specs with available Fedora packages

diff --git a/.github/workflows/fedora.yml b/.github/workflows/fedora.yml
@@ -34,33 +34,33 @@ jobs:
       matrix:
         include:
           - task: make -f Makefile clippy
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: clippy
           - task: PROFILEDIR=debug make -f Makefile build
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
           - task: PROFILEDIR=debug make -f Makefile build-min
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
           - task: PROFILEDIR=debug make -f Makefile stratis-dumpmetadata
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
           - task: make -f Makefile docs-travis
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
           - task: make -f Makefile test
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
           - task: >-
               TANG_URL=localhost
               make -f Makefile test-clevis-loop-should-fail
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
           - task: make -f Makefile build
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
           - task: make -f Makefile build-min
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
     runs-on: ubuntu-22.04
     container:
@@ -95,7 +95,7 @@ jobs:
       matrix:
         include:
           - task: RUST_LOG=stratisd=debug make -f Makefile test-loop
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
     runs-on: ubuntu-22.04
     container:

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -34,10 +34,10 @@ jobs:
       matrix:
         include:
           - task: make -f Makefile fmt-travis
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: rustfmt
           - task: make -f Makefile check-typos
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
     runs-on: ubuntu-22.04
     container:
@@ -74,7 +74,7 @@ jobs:
               TANG_URL=tang
               RUST_LOG=stratisd=debug
               make -f Makefile test-clevis-loop
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
             image: fedora:38  # CURRENT DEVELOPMENT ENVIRONMENT
     runs-on: ubuntu-22.04
@@ -152,7 +152,7 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         with:
           components: cargo
-          toolchain: 1.66.1  # LOWEST SUPPORTED RUST TOOLCHAIN
+          toolchain: 1.69.0  # LOWEST SUPPORTED RUST TOOLCHAIN
       - name: Build stratisd
         run: PROFILEDIR=debug make -f Makefile build-all
       - name: Install stratisd
@@ -176,7 +176,7 @@ jobs:
     runs-on: ubuntu-22.04
     container:
       image: fedora:38  # CURRENT DEVELOPMENT ENVIRONMENT
-      options: --privileged --userns=host --ipc=host -v /run/dbus/system_bus_socket:/run/dbus/system_bus_socket:ro -v /usr/share/dbus-1:/usr/share/dbus-1
+      options: --privileged --userns=host --ipc=host -v /dev:/dev -v /run/udev:/run/udev -v /usr/lib/udev:/usr/lib/udev -v /run/dbus/system_bus_socket:/run/dbus/system_bus_socket:ro -v /usr/share/dbus-1:/usr/share/dbus-1
     steps:
       - uses: actions/checkout@v3
       - name: Install dependencies
@@ -208,7 +208,7 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         with:
           components: cargo
-          toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+          toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
       - name: Run stratisd-min cli tests
         run: make test-stratisd-min
       - name: Run stratis-min cli tests
@@ -260,7 +260,7 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         with:
           components: cargo
-          toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+          toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
       - name: Check out ci repo
         run: git clone https://github.com/stratis-storage/ci.git
       - name: Run ${{ matrix.task }}
@@ -295,7 +295,7 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         with:
           components: cargo
-          toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+          toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
       - name: Build stratisd
         run: PROFILEDIR=debug make -f Makefile build-all
       - name: Install stratisd
@@ -339,7 +339,7 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         with:
           components: cargo
-          toolchain: 1.66.1  # LOWEST SUPPORTED RUST TOOLCHAIN
+          toolchain: 1.69.0  # LOWEST SUPPORTED RUST TOOLCHAIN
       - name: Build stratisd
         run: PROFILEDIR=debug make -f Makefile build-all
       - name: Install stratisd
@@ -353,7 +353,7 @@ jobs:
       - name: Use testing 3.5.2
         run: git checkout tags/v3.5.2 -b version-3.5.2
         working-directory: ./testing
-      - name: Run stratisd_cert.py using Rust ${{ matrix.toolchain }}
+      - name: Run stratisd_cert.py
         run: >
           sudo
           RUST_LOG=stratisd=debug

diff --git a/.github/workflows/python.yml b/.github/workflows/python.yml
@@ -33,9 +33,9 @@ jobs:
       matrix:
         include:
           # MANDATORY CHECKS USING CURRENT DEVELOPMENT ENVIRONMENT
-          - toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+          - toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
           # MANDATORY CHECKS USING LOWEST SUPPORTED ENVIRONMENT PROXY
-          - toolchain: 1.66.1  # LOWEST SUPPORTED RUST TOOLCHAIN
+          - toolchain: 1.69.0  # LOWEST SUPPORTED RUST TOOLCHAIN
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v3
@@ -85,7 +85,7 @@ jobs:
           STRATIS_DUMPMETADATA=/usr/bin/stratis-dumpmetadata
           STRATISD=/usr/libexec/stratisd
           PYTHONPATH=./src
-          udev-tests dump-metadata-tests
+          udev-tests dump-metadata-tests startup-tests
         working-directory: ./tests/client-dbus
 
   # PYTHON-BASED TESTS WITH TANG
@@ -134,7 +134,7 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         with:
           components: cargo
-          toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+          toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
       - name: Build stratisd
         run: PROFILEDIR=debug make -f Makefile build-all
       - name: Install stratisd

diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml
@@ -34,28 +34,28 @@ jobs:
       matrix:
         include:
           - task: make -f Makefile clippy
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: clippy
           - task: PROFILEDIR=debug make -f Makefile build
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
           - task: PROFILEDIR=debug make -f Makefile build-min
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
           - task: PROFILEDIR=debug make -f Makefile stratis-dumpmetadata
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
           - task: make -f Makefile docs-travis
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
           - task: make -f Makefile test
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
           - task: make -f Makefile build
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
           - task: make -f Makefile build-min
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
     runs-on: ubuntu-22.04
     container:
@@ -93,7 +93,7 @@ jobs:
       matrix:
         include:
           - task: RUST_LOG=stratisd=debug make -f Makefile test-loop
-            toolchain: 1.70.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
+            toolchain: 1.71.0  # CURRENT DEVELOPMENT RUST TOOLCHAIN
             components: cargo
     runs-on: ubuntu-22.04
     container:

diff --git a/CHANGES.txt b/CHANGES.txt
@@ -1,3 +1,46 @@
+stratisd 3.5.8
+==============
+Recommended Rust toolchain version: 1.71.0
+Lowest supported Rust toolchain version: 1.69.0
+
+Recommended development platform for Python development: Fedora 38
+
+- Run "cargo update"
+
+- Cherry-picked commits:
+  * Revert to returning an error if pool was partially stopped
+  * Use stop_pool return value to decide StopAction
+  * LiminalDevices::stop_pool() returns a bool
+  * Add Partial to the constructors for StopActions
+  * Add some comments to StopAction
+  * Bug fix for liminal device code
+  * README: update IRC network
+  * github actions: update recommended Rust to 1.71.0
+  * Remove dm::stop_partially_constructed_pool
+  * Fix bug in partially unlocked pool setup
+  * Increase itertools dependency lower bound to 0.11.0
+  * Fix manual_next_back lint error
+  * Start running startup test again, slightly modified
+  * Remove tests target
+  * Use enriched return value in test
+  * Remove code for handling only pool size change
+  * Send blockdev and pool change signal on grow physical
+  * Do not send out signal on UserInfo change before r3
+  * No longer ignore RUSTSEC-2021-0145 in audit target
+  * Specify revision 0 blockdev interface for UserInfo signal
+  * Specify blockdev interfaces for blockdev UserInfo
+  * formatting
+  * remove plymouth remnants
+  * dracut: remove dependency on plymouth
+  * Add comment to DM version check in setup_dm()
+  * Increase devicemapper dependency lower bound to 0.33.5
+  * Require udev support in container stratis-min-cli checks in GitHub Actions
+  * Update lowest supported Rust to 1.69.0
+  * Improve error message for unlock check
+  * Do not use undefined matrix field "toolchain" in GitHub Action 
+  * Fix a source code typo in a test method
+
+
 stratisd 3.5.7
 ==============
 Recommended Rust toolchain version: 1.70.0