allow custom metadata pubkey on solana #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -263,19 +272,26 @@ export default class SolanaStreamClient extends BaseStreamClient { | |||
| const mintPublicKey = new PublicKey(mint); | |||
| const recipientPublicKey = new PublicKey(recipient); | |||
|
|
|||
| const metadata = Keypair.generate(); | |||
| let metadata: Keypair | null = null; | |||
There was a problem hiding this comment.
this is literally copy-pasta from above.
Let's not do that @Yolley :D
There was a problem hiding this comment.
I was going with a quick solution, Solana is the oldest sdk client, it has some duplications.
| sender, | ||
| metadataPubKeys: metadataPubKeys[i] ? [metadataPubKeys[i]] : undefined, |
There was a problem hiding this comment.
So we have 2 arrays: metadataPubKeys and recipients that have the same length.
Can we just assign both props in the single array?
Easier to itterate
There was a problem hiding this comment.
Please provide an example implementation, this is a Solana extension, it is not supported by other chains, so it can't be part of common interfaces.
| @@ -824,9 +842,16 @@ export default class SolanaStreamClient extends BaseStreamClient { | |||
| typeof this.commitment == "string" ? this.commitment : this.commitment.commitment; | |||
| const recipientPublicKey = new PublicKey(recipient.recipient); | |||
| const mintPublicKey = new PublicKey(mint); | |||
| const metadata = Keypair.generate(); | |||
| let metadata: Keypair | null = null; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.