Check whether claim has started in claim #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolginRoman
approved these changes
Mar 28, 2024
RolginRoman
reviewed
Mar 28, 2024
| const endVestingTs = args.endVestingTs.eqn(0) ? nowTs : args.endVestingTs; | ||
| const startVestingTs = args.startVestingTs.eqn(0) ? nowTs : args.startVestingTs; | ||
| if (endVestingTs.gt(startVestingTs) && endVestingTs.sub(startVestingTs).lt(args.unlockPeriod)) { | ||
| throw new Error("Unlock Period can not be less than total Vesting duration!"); |
There was a problem hiding this comment.
I guess you mean vice verse unlock period can't be longer than duration
Suggested change
| throw new Error("Unlock Period can not be less than total Vesting duration!"); | |
| throw new Error("The unlock period cannot be longer than the total vesting duration!"); |
There was a problem hiding this comment.
Dam, you're right. 🌚
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
claimLockedix in claim