Optimise tx confirmation further #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Yolley
commented
Apr 2, 2024
Yolley
commented
- solana: trigger one last status check manually in case blockheight has expired on tx confirmation
RolginRoman
reviewed
Apr 2, 2024
| } | ||
| // exhaust enums to ensure full coverage | ||
| case "processed": | ||
| case "recent": |
There was a problem hiding this comment.
what behavior do you expect here? Just a fallthrough to the final return?
For me personally, this code style is harder to read, I'd suggest to be more specific here and put the return statement inside the switch
nit: btw, // exhaust enums to ensure full coverage
to achieve this you could use
default: {
const defaultValue: never = connection.commitment;
return whatever;
}
The gotcha here is never type, so if any meaningful value falls through to the default case, TS will catch it.
RolginRoman
approved these changes
Apr 2, 2024
| const confirmationStrategy: BlockheightBasedTransactionConfirmationStrategy = { | ||
| lastValidBlockHeight: hash.lastValidBlockHeight + 50, | ||
| signature: bs58.encode(signedTx.signature), | ||
| signature, |
There was a problem hiding this comment.
Is anything from this article useful/applicable?
https://twitter.com/jordaaash/status/1774892864847368230
|
Had to merge this to test on CLI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.