STREAM-1500: throttle tx sending #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolginRoman
reviewed
Apr 22, 2024
Comment on lines
500
to
504
| responses.push( | ||
| ...(await Promise.allSettled([ | ||
| sendAndConfirmStreamRawTransaction(this.connection, batchTx, { hash, context }), | ||
| executeTransaction(this.connection, batchTx.tx, { hash, context }, { sendRate }), | ||
| ])), | ||
| ); |
There was a problem hiding this comment.
why not executeMultipleTransactions here?
There was a problem hiding this comment.
Because we can't, please check comments right on top of this if.
RolginRoman
reviewed
Apr 22, 2024
| preflightCommitment: commitment, | ||
| skipPreflight: true, | ||
| }); | ||
| await sendThrottler.add(async () => |
There was a problem hiding this comment.
Is it required for us to have global-like queue so we don't hit RPCs limit across several invocations of send... APi
There was a problem hiding this comment.
I think it should be handled on the client-side, like FE should have this throttler and pass it to methods. But not in the sdk I think.
RolginRoman
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createMjultiple